-
Notifications
You must be signed in to change notification settings - Fork 204
Mcp undefined filename bug #718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mcp undefined filename bug #718
Conversation
…local repos For local repositories, the webUrl field is undefined since there's no web hosting URL. This fix makes both search_code and list_repos tools fallback to the fileName.text and repoCloneUrl respectively when webUrl is not available.
|
Cursor Agent can help with this pull request. Just |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Heads up @brendan-kellam this PR will slightly change behavior of MCP code search tool to not include web url in |
|
to clarify, will |
Moved the changelog entry for PR #718 from the main CHANGELOG.md to packages/mcp/CHANGELOG.md as requested. Co-authored-by: brendan <[email protected]>
Fixes MCP results returning undefined filenames for local repositories by adding fallbacks for
webUrl.For local repositories, the
webUrlfield is inherently undefined. The MCPsearch_codeandlist_repostools were directly usingfile.webUrlandrepo.webUrlrespectively, leading to "undefined" being displayed. This PR introduces fallbacks tofile.fileName.textfor search results andrepo.repoCloneUrlfor repo listings whenwebUrlis not available.Fixes #717
Linear Issue: SOU-193