ci: build sample apps on PRs and push on main#467
ci: build sample apps on PRs and push on main#467calebschoepp merged 1 commit intospinframework:mainfrom
Conversation
endocrimes
left a comment
There was a problem hiding this comment.
Thanks for the PR!
Unfortunately this change doesn't let the apps build - we'd need to use spin build (not sure if we have a dedicated action) to build the apps - the push that was made conditional was a "build and push", not just push 😅
Thanks for the clarification! @endocrimes I’ve updated the workflow to explicitly run spin build for both pull requests and the main branch, and kept spin push conditional so images are only published on merges to main. Appreciate the guidance 🙂 I also took some time to explore the available actions and couldn’t find a dedicated spin build action. From what I understand, spin push performs both the build and the push by default, so the goal here is to explicitly build the app for PRs and rely on spin push only when merging into main. Please let me know if this understanding is correct. I’ve updated the PR accordingly. |
|
Hey @endocrimes any updates on this PR? |
|
Hi @calebschoepp, thanks for the suggestion! I’ve updated the workflow so spin build now runs only for pull_request events, and the spin push step handles the build when merging to main, avoiding redundant builds. I’ve also fixed the step naming for clarity. Please let me know if this looks good now — appreciate the review! |
Concerns have been addressed.
calebschoepp
left a comment
There was a problem hiding this comment.
LGTM! Thank you for the contribution
|
Oh whoops. Looks like we can't merge it yet b/c the commits are not signed with verified signatures. Would you mind squashing the 3 commits down to a single commit and making sure it is signed. See here for some details on making signed commits. |
ae58627 to
1ee6740
Compare
|
Hey @calebschoepp , Yes — I’ve squashed the three commits into a single signed commit and force-pushed the update. The commit now shows as verified. Please let me know if you’d like any further changes. |
I'm not sure how it happened but it looks like there are still two commits in this PR and the first one is not signed. |
1ee6740 to
e430e17
Compare
Signed-off-by: Achanandhi-M <achanandhi.m@gmail.com>
e430e17 to
392e525
Compare
|
Hey @calebschoepp Thanks for the heads up — you were right. I’ve now squashed the entire PR into a single commit, re-signed it, and force-pushed the update. The PR now shows one verified commit. Please let me know if it looks good to merge now. |
This PR refactors the sample apps GitHub Actions workflow to improve CI behavior by clearly separating pull request builds from main branch publishes.
Sample apps are now built on pull requests to validate changes early, while image publishing remains restricted to merges on the main branch.
Closes #439