Conversation
Signed-off-by: Drew Mullen <drew.mullen@hashicorp.com>
Signed-off-by: Drew Mullen <drew.mullen@hashicorp.com>
|
Morning! Happy Monday and new year. Hoping once you're back from break we can start a discussion on this PR @ryanjbaxter 🙏 . This was a very simple implementation. TBH a lot of copy code. If you want to take these kinds of features another direction please let me know |
|
@mp911de would be more knowledgable here |
|
@drewmullen looks like a decent proposal. Would you mind adding integration tests based on |
fdcd4a7 to
8bc9a02
Compare
Signed-off-by: Drew Mullen <drew.mullen@hashicorp.com>
8bc9a02 to
477fbf4
Compare
|
@mp911de Thank you for pointing out UnboundId, that was pretty straight-forward to implement. Please take a look and see what you think! While I have your attention, I have a couple other small PRs in the project as well, mostly house cleaning, if you have a min can you check those out as well? |
|
Thanks a lot. I'll take the change from here once 5.1 development starts. |
|
@mp911de tyvm for the review and for setting expectation. Do you have a rough ETA? I'm asking because I also realized that we may want to support Vault LDAP Libraries. I havent seen that feature used too much but for completness sake it should probably be included. Depending on your timeline I can try to include in this PR or as a follow on |
|
I wasn’t able to figure out what the libraries/check in/check out functionality is, I am not experienced in LDAP functionality I guess.
I think it will take a month or so until we can proceed.
Am 6. Jan. 2026, 16:43 +0100 schrieb drewmullen ***@***.***>:
… drewmullen left a comment (spring-cloud/spring-cloud-vault#910)
@mp911de tyvm for the review and for setting expectation.
Do you have a rough ETA? I'm asking because I also realized that we may want to support Vault LDAP Libraries. I havent seen that feature used too much but for completness sake it should probably be included. Depending on your timeline I can try to include in this PR or as a follow on
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
I actually have to explore it myself 😅 lol once i have a better understanding ill report back here as to whether or not it belongs in this library. appreciate the heads up |
|
So i spent a little time with libraries. Its a handy little feature. The use case for Vault LDAP libraries is:
Since the accounts exist ahead of time it could also help where LDAP has issues with eventual consistency (which ive heard happens but havent seen it in the wild myself). I will probably add support in a follow up PR if youre OK with it |
|
Thank you for the work on this contribution. Could you please provide an estimated timeline for when this PR may be reviewed or merged? My organization has a significant production use case that depends on LDAP Secret Engine support in Spring Cloud Vault, and having visibility into the expected schedule would greatly assist our planning. Appreciate any update you’re able to share. |
Closes: #745
Added support for ldap secret engine. both dynamic and static roles are supported. After running the tests locally against a working LDAP i have disabled them because its causing CI to fail. LMK how you want to proceed regarding testing
For testing: