Add OAuth2AuthorizedScopesMapper for Client Credentials Grant#2294
Open
nikitanagar08 wants to merge 1 commit intospring-projects:mainfrom
Open
Add OAuth2AuthorizedScopesMapper for Client Credentials Grant#2294nikitanagar08 wants to merge 1 commit intospring-projects:mainfrom
nikitanagar08 wants to merge 1 commit intospring-projects:mainfrom
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
Add OAuth2AuthorizedScopesMapper functional interface and OAuth2AuthorizedScopesContext to allow filtering/transforming authorized scopes before the OAuth2Authorization is persisted. Integrate the mapper into OAuth2ClientCredentialsAuthenticationProvider with a setter following the existing setAuthenticationValidator pattern. Fixes spring-projectsgh-1504 Signed-off-by: Nikita Nagar <permanayan84@gmail.com>
nikitanagar08
force-pushed
the
gh-1504-authorized-scopes-mapper
branch
from
2f9b48a to
6d2ecda
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OAuth2AuthorizedScopesMapperfunctional interface andOAuth2AuthorizedScopesContextto allow filtering/transforming authorized scopes before theOAuth2Authorizationis persistedOAuth2ClientCredentialsAuthenticationProviderwith asetAuthorizedScopesMapper()setter following the existingsetAuthenticationValidator()patternMotivation
Closes gh-1504 — there is currently no way to filter/transform OAuth2 authorized scopes before the
OAuth2Authorizationis persisted. Users must wrap entire authentication providers to modify scopes (e.g., restrictingpayslip.editscope based on user roles).Test plan
setAuthorizedScopesMapperWhenNullThenThrowIllegalArgumentException— verifies null check on setterauthenticateWhenCustomAuthorizedScopesMapperThenUsed— verifies mapper is called and saved authorization uses mapped scopesOAuth2ClientCredentialsAuthenticationProviderTestspass (no regressions)Fixes gh-1504
Signed-off-by: Nikita Nagar permanayan84@gmail.com