Fix flaky reactorNettyAttributes test by using doFinally for synchronous cleanup#36592
Open
Pratapchandradeo wants to merge 1 commit intospring-projects:mainfrom
Open
Conversation
…hronous cleanup - Use doFinally operator to guarantee channel attribute cleanup - Store Connection reference in AtomicReference for access in doFinally - Remove @disabled annotation from reactorNettyAttributes test - This fixes spring-projectsgh-36589 which was caused by async cleanup race condition - Follows reactive best practices using operator-level cleanup Fixes spring-projects#36589 Relates to spring-projects#36158
spring-projects-issues
added
the
status: waiting-for-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
doFinallyoperator in the reactive chain for guaranteed synchronous cleanup:ConnectioninAtomicReferencedoFinally(signal -> clearChannelAttribute(conn))instead of async callback@Disabledannotation from testChanges
connectionRef,doFinallyoperator,clearChannelAttribute()method@DisabledannotationFixes #36589
Relates to #36158
Signed-off-by: Pratap Chandra Deo pratapchandradeo@users.noreply.github.com