AbstractMockHttpServletRequestBuilder#param does not allow null#36599
Open
seregamorph wants to merge 1 commit intospring-projects:mainfrom
Open
AbstractMockHttpServletRequestBuilder#param does not allow null#36599seregamorph wants to merge 1 commit intospring-projects:mainfrom
AbstractMockHttpServletRequestBuilder#param does not allow null#36599seregamorph wants to merge 1 commit intospring-projects:mainfrom
Conversation
Signed-off-by: seregamorph <serega.morph@gmail.com>
AbstractMockHttpServletRequestBuilder#param does not allow null
Contributor
|
@seregamorph If we do this change, we are going to need to update the nullability in much more other places (fields, @rstoyanchev Could you please confirm query parameters value should be nullable? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem statement
Since Spring Framework 7.0 it's not possible to use
nullvalue as an argument for MockMvc query parameters.E.g. for such snippet of Kotlin code
mockMvc .perform( get("/url") .param("limit", "1"), .param("cursor", null) // <- compilation fails now ).andExpect(status().isOk)While
nullvalue is a legal value for query parameters (it's serialized as "?paramName" in the query string without following=(and is expected in our test on the server side)Original change: bc5d771 by @sdeleuze
Proposed solution
Mark argument
@Nullablefor Java callers and Kotlin extension.