Conversation
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
added
in: docs
Contributor
|
Hi, @c-arianna! Thank you for the PR. It appears that you have added other cleanup as well, which is great. Will you please place these in separate commits? In this way, the commit that fixes the linked issue only contains those changes. This simplifies future research as well as simplifying backporting. From what I can tell, you have four separate improvements:
Would you please separate these into separate commits? Only the first one should have "Closes gh-18376" at the end. If you have trouble with this, please let me know and I can help. |
jzheaux
added
the
status: waiting-for-feedback
Closes spring-projectsgh-18376 Signed-off-by: arianna <arianna.comi03@gmail.com>
Signed-off-by: arianna <arianna.comi03@gmail.com>
Signed-off-by: arianna <arianna.comi03@gmail.com>
- Fix wrong docs link in Servlet - SAML2 Log In Overview - Fix examples in Servlet - SAML2 Authentication Responses - Fix examples in Servlet - SAML2 Logout Signed-off-by: arianna <arianna.comi03@gmail.com>
Contributor
Author
|
Hi @jzheaux, sorry about that and thanks for the feedback! |
spring-projects-issues
added
status: feedback-provided
Contributor
|
Thanks, @c-arianna! This will merge into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes gh-18376