Add nullability contract to PasswordEncoder#encode implementations#18490
Merged
rwinch merged 1 commit intospring-projects:mainfrom Feb 19, 2026
Merged
Add nullability contract to PasswordEncoder#encode implementations#18490rwinch merged 1 commit intospring-projects:mainfrom
PasswordEncoder#encode implementations#18490rwinch merged 1 commit intospring-projects:mainfrom
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
scordio
force-pushed
the
refine-nullability
branch
2 times, most recently
from
a2c1fa7 to
ed937d9
Compare
rwinch
force-pushed
the
refine-nullability
branch
from
ed937d9 to
17b6992
Compare
rwinch
added a commit
to scordio/spring-security
that referenced
this pull request
Feb 2, 2026
rwinch
added
in: core
Member
|
Thanks for the PR @scordio! I pushed a minor change to move |
Contributor
Author
|
Oh, I have no idea how I missed it... 😅 Thanks for fixing it! |
rwinch
force-pushed
the
refine-nullability
branch
from
8f02aff to
8ab6d3e
Compare
Member
|
I pushed an empty commit and then removed it to try and get the CI to go, but it appears that this is related to reported GitHub Actions being stuck in the queue for extended periods of times. Once that gets sorted and the build passes this should merge |
Contributor
Author
|
In case raising a fresh PR would make things simpler with the CI, just let me know and I'll do it 🙂 |
rwinch
added a commit
to scordio/spring-security
that referenced
this pull request
Feb 3, 2026
rwinch
force-pushed
the
refine-nullability
branch
from
8ab6d3e to
42e3599
Compare
rwinch
added a commit
to scordio/spring-security
that referenced
this pull request
Feb 3, 2026
rwinch
force-pushed
the
refine-nullability
branch
from
42e3599 to
ca2dd4c
Compare
auto-merge was automatically disabled
February 15, 2026 14:42
Head branch was pushed to by a user without write access
scordio
force-pushed
the
refine-nullability
branch
2 times, most recently
from
27b1a28 to
271344e
Compare
Contributor
Author
|
I rebased and squashed everything in a single commit. |
Signed-off-by: Stefano Cordio <stefano.cordio@gmail.com>AbstractValidatingPasswordEncoder.java
rwinch
force-pushed
the
refine-nullability
branch
from
271344e to
781d2fa
Compare
Member
|
Thanks for the Pull Request and helping with the continual rebasing efforts! This is now merged into main 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #18334 (comment).