Fix : Wrap IllegalStateException as BadJwtException in NimbusJwtDecoder#19032
Open
chanani wants to merge 2 commits intospring-projects:mainfrom
Open
Fix : Wrap IllegalStateException as BadJwtException in NimbusJwtDecoder#19032chanani wants to merge 2 commits intospring-projects:mainfrom
chanani wants to merge 2 commits intospring-projects:mainfrom
Conversation
Previously, an invalid issuer caused IllegalStateException to propagate instead of BadJwtException, preventing AuthenticationEntryPoint from being invoked. Closes spring-projectsgh-18388 Signed-off-by: CHANHAN <130114269+chanani@users.noreply.github.com>
spring-projects-issues
added
the
status: waiting-for-triage
…erTests Signed-off-by: CHANHAN <130114269+chanani@users.noreply.github.com>
Contributor
Author
|
Hi @rwinch, I'd like to work on this issue. The fix catches Please review my PR. Thank you ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using OAuth2 Resource Server with JWT authentication, if a client
sends a token with an issuer different from the configured
issuer-uri,NimbusJwtDecoder.createJwt()propagates anIllegalStateExceptionfrom
JwtDecoderProviderConfigurationUtils.validateIssuer().Since
JwtAuthenticationProvideronly catchesJwtException,the
IllegalStateExceptionescapes the authentication pipeline,causing the configured
AuthenticationEntryPointto not be invoked.Solution
Catch
IllegalStateExceptioninNimbusJwtDecoder.createJwt()andwrap it as
BadJwtExceptionso that the exception is properly handledby the authentication pipeline.
Tests
decodeWhenIllegalStateExceptionThenThrowsBadJwtException()in
NimbusJwtDecoderTestsFixes gh-18388