Move some metadata from setup.cfg to pyproject.toml#426
Move some metadata from setup.cfg to pyproject.toml#426cocolato wants to merge 4 commits intosqlalchemy:mainfrom
Conversation
cocolato
force-pushed
the
feat/pyproject
branch
from
c203814 to
d66d8e4
Compare
sqla-tester
left a comment
sqla-tester
left a comment
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision d66d8e4 of this pull request into gerrit so we can run tests and reviews and stuff
sqla-tester
left a comment
sqla-tester
left a comment
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision d66d8e4 of this pull request into gerrit so we can run tests and reviews and stuff
sqla-tester
left a comment
sqla-tester
left a comment
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision d66d8e4 of this pull request into gerrit so we can run tests and reviews and stuff
sqla-tester
left a comment
sqla-tester
left a comment
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision d66d8e4 of this pull request into gerrit so we can run tests and reviews and stuff
sqla-tester
left a comment
sqla-tester
left a comment
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision d66d8e4 of this pull request into gerrit so we can run tests and reviews and stuff
sqla-tester
left a comment
sqla-tester
left a comment
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision d66d8e4 of this pull request into gerrit so we can run tests and reviews and stuff
|
Patchset d66d8e4 added to existing Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/6102 |
|
sorry doing some config cahnges here |
sqla-tester
left a comment
sqla-tester
left a comment
There was a problem hiding this comment.
Federico Caselli (CaselIT) wrote:
code review left on gerrit
View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/6102
|
|
||
| [project] | ||
| name = "Mako" | ||
| version = "1.3.11" |
There was a problem hiding this comment.
Federico Caselli (CaselIT) wrote:
this should be dynamic, since before it was attr: mako.__version__
See https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html#dynamic-metadata
View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/6102
|
Thanks! It has been updated. |
sqla-tester
left a comment
sqla-tester
left a comment
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of CaselIT to try to get revision 1ef7ade of this pull request into gerrit so we can run tests and reviews and stuff
|
Patchset 1ef7ade added to existing Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/6102 |
|
Ref: https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html#configuring-setuptools-using-pyproject-toml-files. Support for project.license-files and SPDX license expressions in project.license (PEP 639) were introduced in version 77.0.0. |
|
you can take a look at what's done in alembic or sqlalchemy, that both use pyproject in a fairly similar way:
it seems that both just require setuptools >=77.0.3 |
|
I've removed the |
sqla-tester
left a comment
sqla-tester
left a comment
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of CaselIT to try to get revision c52e72a of this pull request into gerrit so we can run tests and reviews and stuff
|
Patchset c52e72a added to existing Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/6102 |
sqla-tester
left a comment
sqla-tester
left a comment
There was a problem hiding this comment.
Michael Bayer (zzzeek) wrote:
code review left on gerrit
View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/6102
|
|
||
| [project] | ||
| name = "Mako" | ||
| dynamic = ["version"] |
There was a problem hiding this comment.
Michael Bayer (zzzeek) wrote:
Done
View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/6102
| [project.urls] | ||
| Homepage = "https://www.makotemplates.org/" | ||
| Source = "https://github.com/sqlalchemy/mako" | ||
| Documentation = "https://docs.makotemplates.org" |
There was a problem hiding this comment.
Michael Bayer (zzzeek) wrote:
Done
View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/6102
| [build-system] | ||
| build-backend = 'setuptools.build_meta' | ||
| requires = ['setuptools >= 47', 'wheel'] | ||
| requires = ["setuptools>=77.0.3"] |
There was a problem hiding this comment.
Michael Bayer (zzzeek) wrote:
this is arbitrary. should be 61.2 for python 3.10
View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/6102
There was a problem hiding this comment.
Michael Bayer (zzzeek) wrote:
Done
View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/6102
| "Intended Audience :: Developers", | ||
| "Programming Language :: Python", | ||
| "Programming Language :: Python :: 3", | ||
| "Programming Language :: Python :: 3.8", |
There was a problem hiding this comment.
Michael Bayer (zzzeek) wrote:
py3.10
View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/6102
There was a problem hiding this comment.
Michael Bayer (zzzeek) wrote:
Done
View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/6102
| ] | ||
| requires-python = ">=3.8" | ||
| dependencies = [ | ||
| "MarkupSafe>=0.9.2" |
There was a problem hiding this comment.
Michael Bayer (zzzeek) wrote:
2.0
View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/6102
There was a problem hiding this comment.
Michael Bayer (zzzeek) wrote:
Done
View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/6102
|
|
||
| [project.entry-points."pygments.lexers"] | ||
| mako = "mako.ext.pygmentplugin:MakoLexer" | ||
| html_mako = "mako.ext.pygmentplugin:MakoHtmlLexer" |
There was a problem hiding this comment.
Michael Bayer (zzzeek) wrote:
these are wrong, should be "html+mako", etc
View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/6102
There was a problem hiding this comment.
Michael Bayer (zzzeek) wrote:
Done
View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/6102
|
Michael Bayer (zzzeek) wrote: code review left on gerrit View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/6102 |
|
Michael Bayer (zzzeek) wrote: we have a newer change that is much broader in scope than this View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/6102 |
|
Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/6102 has been abandoned. That means that at least for the moment I need to close this pull request. Sorry it didn't work out :( |
sqla-tester
left a comment
sqla-tester
left a comment
There was a problem hiding this comment.
Federico Caselli (CaselIT) wrote:
Just some minor things in pyproject
View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/6102
| name = "Mako" | ||
| dynamic = ["version"] | ||
| description = "A super-fast templating language that borrows the best ideas from the existing templating languages." | ||
| readme = "README.rst" |
There was a problem hiding this comment.
Federico Caselli (CaselIT) wrote:
I think we should specify the license file.
Just copy from SQLAlchemy
View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/6102
4 participants
Ref: https://peps.python.org/pep-0518/#sticking-with-setup-cfg
Fix: #420
Migrating the static matadata to project.toml will also help us to use some modern package managers such as: poetry、uv、pdm.