Skip to content

chore: bump Rust edition to 2024 and apply cargo fix + clippy updates#841

Open
Saul-STFC wants to merge 1 commit into
stackabletech:mainfrom
Saul-STFC:rust-2024-upgrade
Open

chore: bump Rust edition to 2024 and apply cargo fix + clippy updates#841
Saul-STFC wants to merge 1 commit into
stackabletech:mainfrom
Saul-STFC:rust-2024-upgrade

Conversation

@Saul-STFC
Copy link
Copy Markdown

@Saul-STFC Saul-STFC commented Jun 2, 2026

Run cargo fix --edition and resolve resulting warnings:

  • Add use<> syntax to impl Trait return types (auto-fixed)
  • Fix Rust 2024 temporary drop order changes across async main tasks and backend helpers
    • Unnest nested Ok(Json(...)) block in user-info endpoint to isolate temporary lifetimes
    • Rewrite immediate let bindings to use ? followed by explicit Ok(...) returns
    • Fix Rust 2024 temporary drop order change by simplifying _initial_reconcile_rx handling
  • Apply Clippy suggestions

Description

Please add a description here. This will become the commit message of the merge request later.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

Run `cargo fix --edition` and resolve resulting warnings:

- Add `use<>` syntax to `impl Trait` return types (auto-fixed)
- Fix Rust 2024 temporary drop order changes across async main tasks and backend helpers
  - Unnest nested `Ok(Json(...))` block in user-info endpoint to isolate temporary lifetimes
  - Rewrite immediate `let` bindings to use `?` followed by explicit `Ok(...)` returns
  - Fix Rust 2024 temporary drop order change by simplifying `_initial_reconcile_rx` handling
- Apply Clippy suggestions
  - Use `&& let` chaining instead of nested `if let` blocks in `controller.rs`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: Waiting for Review

Development

Successfully merging this pull request may close these issues.

2 participants