chore: bump Rust edition to 2024 and apply cargo fix + clippy updates#841
Open
Saul-STFC wants to merge 1 commit into
Open
chore: bump Rust edition to 2024 and apply cargo fix + clippy updates#841Saul-STFC wants to merge 1 commit into
Saul-STFC wants to merge 1 commit into
Conversation
Run `cargo fix --edition` and resolve resulting warnings: - Add `use<>` syntax to `impl Trait` return types (auto-fixed) - Fix Rust 2024 temporary drop order changes across async main tasks and backend helpers - Unnest nested `Ok(Json(...))` block in user-info endpoint to isolate temporary lifetimes - Rewrite immediate `let` bindings to use `?` followed by explicit `Ok(...)` returns - Fix Rust 2024 temporary drop order change by simplifying `_initial_reconcile_rx` handling - Apply Clippy suggestions - Use `&& let` chaining instead of nested `if let` blocks in `controller.rs`
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run
cargo fix --editionand resolve resulting warnings:use<>syntax toimpl Traitreturn types (auto-fixed)Ok(Json(...))block in user-info endpoint to isolate temporary lifetimesletbindings to use?followed by explicitOk(...)returns_initial_reconcile_rxhandling&& letchaining instead of nestedif letblocks incontroller.rsPart of Bump our Rust code to 2024 edition issues#832
Description
Please add a description here. This will become the commit message of the merge request later.
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker