chore: Bump Rust edition to 2024#710
Conversation
…actors Upgrade workspace and crates to Rust 2024 edition and apply tool-driven fixes: - Bump Rust edition from 2021 to 2024 across workspace crates (Cargo.toml, Cargo.nix) - Update `rustls-webpki` dependency to 0.103.13 - Apply `cargo fix --edition` changes - Add `use<>` lifetime capture in `impl Trait` return types for iterators - Apply Clippy suggestions and minor refactors - Simplify iterator-returning functions with correct lifetime capture syntax - Refactor `trystream_any` to fix warning
Saul-STFC
force-pushed
the
rust-2024-upgrade
branch
from
ea1e686 to
fd0995b
Compare
| while let Some(value) = stream.next().await { | ||
| if let Ok(true) | Err(_) = value { | ||
| return value; | ||
| loop { |
There was a problem hiding this comment.
I personally found the existing code a bit easier to read to be honest.
But I let you decide if we want to keep it and silence clippy
There was a problem hiding this comment.
In that case I suggest we slap a #[allow(clippy::xxx)] at the existing code and keep that
There was a problem hiding this comment.
This looks like it's just cargo fix being overly pessimistic about the 2024 if let lifetime changes. The old while let should still be fine here.
There was a problem hiding this comment.
I have a bit of mixed feelings about touching rust/p12. As documented in rust/p12/README.md it's a fork of https://github.com/hjiayz/p12/. We can hopefully get rid of it eventually.
So it's nice to maintain it, on the other hand this increases the diff to upstream...
There was a problem hiding this comment.
Fair. Although I'm unsure we have really maintained it (apologies if we do, and I missed it).
In this case, shall we leave p12 on 2021? Is cargo ok with multiple workspace members using different editions?
sbernauer
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
Explicitly selecting TryFutureExt::into_future
Techassi
changed the title
4 participants
Upgrade workspace and crates to Rust 2024 edition and apply tool-driven fixes:
rustls-webpkidependency to 0.103.13 to fix security vulnerability warningscargo fix --editionchangesuse<>lifetime capture inimpl Traitreturn types for iteratorstrystream_anyto fix warningPart of Bump our Rust code to 2024 edition issues#832
Description
Please add a description here. This will become the commit message of the merge request later.
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker