Skip to content

fix: application handling of multiple references to the same SecretClass#655

Merged
razvan merged 6 commits intomainfrom
fix/653
Feb 17, 2026
Merged

fix: application handling of multiple references to the same SecretClass#655
razvan merged 6 commits intomainfrom
fix/653

Conversation

@razvan
Copy link
Member

@razvan razvan commented Feb 16, 2026

Description

Fixes #653

In addition to the problem described in #653, this also fixes the handling of SecretClass certificates in the Spark submit pod.

Previously the secret volumes containing certificates were mounted in the submit Pod, but the trust store was not created and the JVM options for the submit its self were missing.

This PR also cleans up the history test to use a single S3 endpoint and thus confirm that #653 is fixed.

🟢 Integration tests (run locally with reduced number of Spark versions):

--- PASS: kuttl (1486.21s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/smoke_openshift-false_spark-4.1.1_s3-use-tls-false (167.47s)
        --- PASS: kuttl/harness/spark-history-server_openshift-false_spark-4.1.1_s3-use-tls-true (181.24s)
        --- PASS: kuttl/harness/resources_openshift-false_spark-4.1.1 (58.98s)
        --- PASS: kuttl/harness/pyspark-ny-public-s3-image_openshift-false_spark-4.1.1_ny-tlc-report-0.3.0 (144.67s)
        --- PASS: kuttl/harness/iceberg_openshift-false_spark-iceberg-4.0.1 (57.95s)
        --- PASS: kuttl/harness/spark-examples_openshift-false_spark-4.1.1 (49.44s)
        --- PASS: kuttl/harness/delta-lake_openshift-false_spark-delta-lake-4.0.1 (267.54s)
        --- PASS: kuttl/harness/spark-history-server_openshift-false_spark-4.1.1_s3-use-tls-false (172.02s)
        --- PASS: kuttl/harness/hbase-connector_openshift-false_spark-hbase-connector-3.5.8_hbase-2.6.4_hdfs-latest-3.4.2_zookeeper-latest-3.9.4 (294.14s)
        --- PASS: kuttl/harness/custom-log-directory_openshift-false_spark-4.1.1_hdfs-latest-3.4.2_zookeeper-latest-3.9.4 (227.87s)
        --- PASS: kuttl/harness/spark-ny-public-s3_openshift-false_spark-4.1.1_s3-use-tls-true (127.88s)
        --- PASS: kuttl/harness/spark-pi-private-s3_openshift-false_spark-4.1.1 (110.58s)
        --- PASS: kuttl/harness/spark-ny-public-s3_openshift-false_spark-4.1.1_s3-use-tls-false (129.21s)
        --- PASS: kuttl/harness/overrides_openshift-false_spark-4.1.1 (141.67s)
        --- PASS: kuttl/harness/spark-connect_openshift-false_spark-connect-4.1.1 (119.93s)
        --- PASS: kuttl/harness/pyspark-ny-public-s3_openshift-false_spark-4.1.1 (122.83s)
        --- PASS: kuttl/harness/smoke_openshift-false_spark-4.1.1_s3-use-tls-true (166.51s)
        --- PASS: kuttl/harness/logging_openshift-false_spark-logging-4.1.1_ny-tlc-report-0.3.0 (319.71s)
PASS

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@razvan razvan self-assigned this Feb 16, 2026
@razvan razvan moved this to Development: Waiting for Review in Stackable Engineering Feb 16, 2026
@razvan razvan requested a review from a team February 16, 2026 16:25
@maltesander maltesander self-requested a review February 17, 2026 08:38
@maltesander maltesander moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Feb 17, 2026
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things, LGTM other wise.

razvan and others added 3 commits February 17, 2026 12:47
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@razvan razvan requested a review from maltesander February 17, 2026 11:52
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@razvan razvan added this pull request to the merge queue Feb 17, 2026
Merged via the queue into main with commit c3ddc7b Feb 17, 2026
12 checks passed
@razvan razvan deleted the fix/653 branch February 17, 2026 12:13
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: Done

Development

Successfully merging this pull request may close these issues.

Clashing volumes when SecretClass is used multiple times

2 participants