feat(dom): DOM - toBeEmpty #162
Open
+97
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SbsCruz
commented
Jan 16, 2026
suany0805
reviewed
Jan 28, 2026
| } | ||
|
|
||
| export function isElementEmpty (element: Element): boolean { | ||
| const nonCommentChildNodes = [...element.childNodes].filter(child => child.nodeType !== 8); |
Contributor
There was a problem hiding this comment.
Why do we use nodeType != 8. What does 8 represent?
You could refactor this to be a constant based on what it is.
const NODE_TYPE_ABCD _ID = 8;
then you can use the constant so we can avoid hardcoding multiple times this type of data on different scenarios.
Contributor
Author
There was a problem hiding this comment.
number 8 represents the COMMENT_NODE, (as shown here) so they are excluded from the function,
and sure, i will make it a constant so it's more legible, thanks!
suany0805
reviewed
Jan 28, 2026
Contributor
suany0805
left a comment
suany0805
left a comment
There was a problem hiding this comment.
Nice work! just left a couple of comments! Let me know if you would like to pair to review them :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the toBeEmpty matcher.