Closed
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the encrypted value for the tenks_vault_password secret in zuul.d/secrets.yaml. This appears to be a routine secret rotation or correction. The way the secret is defined and used in the associated Ansible playbook follows good practices, such as using no_log: true to prevent accidental exposure. Since the secret is encrypted, its contents cannot be verified, but the change itself is structurally correct and I found no issues in the surrounding code.
d0d304d to
d11f857
Compare
d11f857 to
315d579
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.