clean up stackit client#1060
Open
aniruddha2000 wants to merge 44 commits into
Open
Conversation
ske-prow
Bot
added
the
kind/cleanup
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ske-prow
Bot
added
needs-rebase
nschad
requested changes
May 11, 2026
aniruddha2000
force-pushed
the
cleanup-stackit-client
branch
3 times, most recently
from
1819545 to
34cd84b
Compare
ske-prow
Bot
removed
the
needs-rebase
ske-prow
Bot
added
the
needs-rebase
# Conflicts: # go.mod # go.sum # Conflicts: # go.mod
aniruddha2000
force-pushed
the
cleanup-stackit-client
branch
from
391a765 to
9f381fc
Compare
ske-prow
Bot
removed
the
needs-rebase
nschad
requested changes
Jun 3, 2026
| if err != nil { | ||
| klog.Fatalf("Failed to create IaaS client: %v", err) | ||
| iaasOpts := []sdkconfig.ConfigurationOption{ | ||
| sdkconfig.WithHTTPClient(metrics.NewInstrumentedHTTPClient()), // TODO: Ask if this is needed or not |
Contributor
There was a problem hiding this comment.
What about the comment? I thin we need it
Did you test it?
| iaasClient, err := stackitclient.New(cfg.Global.Region, cfg.Global.ProjectID).IaaS(iaasOpts) | ||
| if err != nil { | ||
| klog.Fatalf("Failed to create STACKIT provider: %v", err) | ||
| klog.Fatalf("Failed to create STACKIT stackitclient: %v", err) |
Contributor
There was a problem hiding this comment.
Suggested change
| klog.Fatalf("Failed to create STACKIT stackitclient: %v", err) | |
| klog.Fatalf("Failed to create STACKIT provider: %v", err) |
| type Instances struct { | ||
| regionProviderID bool | ||
| iaasClient stackit.NodeClient | ||
| iaasClient stackitclient.IaaSClient |
| loadBalancer.GetLoadBalancerName(context.Background(), clusterName, svc), | ||
| versionMatcher("current-version"), | ||
| ).MinTimes(1).Return(myLb, nil) | ||
| ).MinTimes(1).Return(nil) |
Contributor
There was a problem hiding this comment.
Why is the return "myLB" gone?
| ), | ||
| ).MinTimes(1).Return(myLb, nil), | ||
| mockClient.EXPECT().DeleteCredentials(gomock.Any(), projectID, gomock.Any()).MinTimes(1).Return(nil), | ||
| ).MinTimes(1).Return(nil), |
| payload := iaas.ResizeVolumePayload{ | ||
| Size: volSizeGB, | ||
| } | ||
| err = cloud.ExpandVolume(ctx, volumeID, *volume.Status, payload) |
Contributor
There was a problem hiding this comment.
Suggested change
| err = cloud.ExpandVolume(ctx, volumeID, *volume.Status, payload) | |
| err = cloud.ExpandVolume(ctx, volumeID, *volume.Status, iaas.ResizeVolumePayload{Size: volSizeGB}) |
Can we put this into one line?
| Do(func(_ context.Context, opts *iaas.CreateVolumePayload) { | ||
| iaasClient.EXPECT(). | ||
| CreateVolume(gomock.Any(), gomock.Any()). | ||
| DoAndReturn(func(_ context.Context, opts *iaas.CreateVolumePayload) (*iaas.Volume, error) { |
Contributor
There was a problem hiding this comment.
Why was the Do changed into DoAndREturn?
| }, nil | ||
| } | ||
|
|
||
| func (i iaasClient) GetServer(ctx context.Context, serverID string) (*iaas.Server, error) { |
Contributor
There was a problem hiding this comment.
Why is this a value receiver instead of a pointer reviewer?
func (i *iaasClient) vs
func (i iaasClient) | }, nil | ||
| } | ||
|
|
||
| func (l loadBalancingClient) CreateLoadBalancer(ctx context.Context, payload *loadbalancer.CreateLoadBalancerPayload) (*loadbalancer.LoadBalancer, error) { |
Contributor
There was a problem hiding this comment.
Why the value receiver? See above IaaSClient
Contributor
There was a problem hiding this comment.
We should also here add the X-Request-Id header copy to error message wrapper.
I would prefer however if we can find a way to make this prettier than individually wrapping each call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/kind cleanup
What this PR does / why we need it:
This PR introduces clean up for the stackit client and the mocks.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Breaking changes: