feat(ske): port to v2api version of SDK#1337
Open
MichaelEischer wants to merge 2 commits intostackitcloud:mainfrom
Open
feat(ske): port to v2api version of SDK#1337MichaelEischer wants to merge 2 commits intostackitcloud:mainfrom
MichaelEischer wants to merge 2 commits intostackitcloud:mainfrom
Conversation
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adapt the SKE commands to the latest sdk version, which includes the API changes for #1328 .
There is one slight behavior change though: decoding into
CreateOrUpdateClusterPayloadfor theske cluster createorske cluster updatecommands now returns an error if an unknown field is set in the input. This is probably a good idea, but is probably noteworthy. A possibly common cause of this problem is usingstackit ske cluster describe -ojsonto dump the cluster config, modify it and update it usingstackit ske cluster update. Now, instead ofdescribethestackit ske cluster generate-payloadcommand has to be used.Checklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)