Skip to content

feat(secretsmanager): add support for kms keys#1312

Merged
marceljk merged 1 commit intomainfrom
feat/STACKITTPR-539-add-kms-key-support-in-secrets-manager
Mar 25, 2026
Merged

feat(secretsmanager): add support for kms keys#1312
marceljk merged 1 commit intomainfrom
feat/STACKITTPR-539-add-kms-key-support-in-secrets-manager

Conversation

@marceljk
Copy link
Contributor

Description

relates to STACKITTPR-539

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@marceljk marceljk requested a review from a team as a code owner March 19, 2026 12:07
@marceljk marceljk force-pushed the feat/STACKITTPR-539-add-kms-key-support-in-secrets-manager branch 2 times, most recently from cda8abe to 61ef56b Compare March 24, 2026 13:09
@marceljk marceljk force-pushed the feat/STACKITTPR-539-add-kms-key-support-in-secrets-manager branch from 61ef56b to 62a1b8b Compare March 25, 2026 08:58
@marceljk marceljk enabled auto-merge (squash) March 25, 2026 08:59
@marceljk marceljk merged commit 91c0726 into main Mar 25, 2026
3 checks passed
@marceljk marceljk deleted the feat/STACKITTPR-539-add-kms-key-support-in-secrets-manager branch March 25, 2026 09:02
@github-actions
Copy link

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/secretsmanager 0.00% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/secretsmanager/instance 23.22% (+2.17%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/secretsmanager/instance/datasource.go 0.00% (ø) 41 0 41
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/secretsmanager/instance/resource.go 27.43% (+2.19%) 226 (+20) 62 (+10) 164 (+10) 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/secretsmanager/instance/resource_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/secretsmanager/secretsmanager_acc_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants