Skip to content

fix(secretsmanager): Allow inplace update of user description #1455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
j1n-o9r wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(secretsmanager): Allow inplace update of user description #1455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions stackit/internal/services/secretsmanager/secretsmanager_acc_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ func configVarsMinUpdated() config.Variables {
tempConfig := maps.Clone(testConfigVarsMin)
tempConfig["instance_name"] = config.StringVariable(testutil.ConvertConfigVariable(tempConfig["instance_name"]) + "-updated")
tempConfig["write_enabled"] = config.BoolVariable(false)
tempConfig["description"] = config.StringVariable(testutil.ConvertConfigVariable(tempConfig["description"]) + "-updated")
return tempConfig
}

Expand All @@ -62,6 +63,7 @@ func configVarsMaxUpdated() config.Variables {
tempConfig["write_enabled"] = config.BoolVariable(false)
tempConfig["use_kms_key"] = config.BoolVariable(false)
tempConfig["acl2"] = config.StringVariable("10.100.2.0/24")
tempConfig["description"] = config.StringVariable(testutil.ConvertConfigVariable(tempConfig["description"]) + "-updated")
return tempConfig
}

Expand Down
6 changes: 2 additions & 4 deletions stackit/internal/services/secretsmanager/user/resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,9 +135,6 @@ func (r *userResource) Schema(_ context.Context, _ resource.SchemaRequest, resp
"description": schema.StringAttribute{
Description: descriptions["description"],
Required: true,
PlanModifiers: []planmodifier.String{
stringplanmodifier.RequiresReplace(),
},
},
"write_enabled": schema.BoolAttribute{
Description: descriptions["write_enabled"],
Expand Down Expand Up @@ -396,7 +393,8 @@ func toUpdatePayload(model *Model) (*secretsmanager.UpdateUserPayload, error) {
return nil, fmt.Errorf("nil model")
}
return &secretsmanager.UpdateUserPayload{
Write: conversion.BoolValueToPointer(model.WriteEnabled),
Description: conversion.StringValueToPointer(model.Description),
Write: conversion.BoolValueToPointer(model.WriteEnabled),
}, nil
}

Expand Down
7 changes: 5 additions & 2 deletions stackit/internal/services/secretsmanager/user/resource_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,17 +229,20 @@ func TestToUpdatePayload(t *testing.T) {
"default_values",
&Model{},
&secretsmanager.UpdateUserPayload{
Write: nil,
Description: nil,
Write: nil,
},
true,
},
{
"simple_values",
&Model{
Description: types.StringValue("description"),
WriteEnabled: types.BoolValue(false),
},
&secretsmanager.UpdateUserPayload{
Write: new(false),
Description: new("description"),
Write: new(false),
},
true,
},
Expand Down
Loading