Skip to content

Add code review assist skill and expand vMCP anti-patterns#4302

Merged
JAORMX merged 2 commits intomainfrom
jerm/code-review-skill-improvements
Mar 23, 2026
Merged

Add code review assist skill and expand vMCP anti-patterns#4302
JAORMX merged 2 commits intomainfrom
jerm/code-review-skill-improvements

Conversation

@jerm-dro
Copy link
Contributor

@jerm-dro jerm-dro commented Mar 20, 2026

Summary

  • After a review session covering 5 PRs, recurring patterns emerged where the review process consistently missed two classes of issues: unnecessary abstractions that modify stable interfaces, and premature optimizations introduced without evidence. This PR codifies those learnings.
  • Adds a new Claude Code skill (code-review-assist) for human-in-the-loop PR review sessions that structures review output, tracks what the skill surfaces vs. what the reviewer actually cares about, and proposes skill improvements at session end.
  • Adds two new anti-patterns (#8 Unnecessary Abstraction / Interface Modification, #9 Premature Optimization) to vmcp-anti-patterns.md.

Type of change

  • Other (describe): Claude Code skill + review convention improvements

Test plan

  • Manual testing (describe below)

Used the skill across a review session covering PRs #4286, #4294, #4290, #4241, #4299. Compared skill output against actual reviewer comments to identify gaps, then updated the skill and rules based on observed patterns.

Changes

File Change
.claude/skills/code-review-assist/SKILL.md New skill: human-in-the-loop review augmentation with session tracking
.claude/rules/vmcp-anti-patterns.md Added anti-patterns #8 (unnecessary abstraction) and #9 (premature optimization)

Special notes for reviewers

The code-review-assist skill is distinct from the existing code-reviewer agent — the agent runs autonomously checking conventions, while this skill is for interactive sessions where the reviewer is actively making decisions. The session tracking section is designed so each review session improves the next.

Generated with Claude Code

Adds a new Claude Code skill (code-review-assist) for human-in-the-loop
PR review sessions. The skill structures review output, tracks session
notes for continuous improvement, and focuses on surfacing what matters
most to the reviewer.

Adds two new anti-patterns to vmcp-anti-patterns.md based on recurring
patterns observed during review:
- Unnecessary abstraction / interface modification
- Premature optimization

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions github-actions bot added the size/XS Extra small PR: < 100 lines changed label Mar 20, 2026
@codecov
Copy link

codecov bot commented Mar 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.84%. Comparing base (4bb1016) to head (bcbb1ec).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4302      +/-   ##
==========================================
+ Coverage   68.77%   68.84%   +0.07%     
==========================================
  Files         473      473              
  Lines       47917    47917              
==========================================
+ Hits        32955    32989      +34     
+ Misses      12309    12269      -40     
- Partials     2653     2659       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

When a PR touches vMCP code, the skill now runs vmcp-review and
surfaces the most important findings inline rather than requiring
the reviewer to run both skills separately.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions github-actions bot added size/XS Extra small PR: < 100 lines changed and removed size/XS Extra small PR: < 100 lines changed labels Mar 20, 2026
@JAORMX JAORMX merged commit dee0cf8 into main Mar 23, 2026
39 checks passed
@JAORMX JAORMX deleted the jerm/code-review-skill-improvements branch March 23, 2026 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Extra small PR: < 100 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants