fix(composer): expand template expressions in elicitation messages#4313
Open
saschabuehrle wants to merge 1 commit intostacklok:mainfrom
Open
fix(composer): expand template expressions in elicitation messages#4313saschabuehrle wants to merge 1 commit intostacklok:mainfrom
saschabuehrle wants to merge 1 commit intostacklok:mainfrom
Conversation
saschabuehrle
requested review from
JAORMX,
amirejaz,
jerm-dro,
jhrozek and
yrobla
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
#4312 — Template expressions like
{{.params.owner}}in elicitation stepmessagefields are passed through as raw placeholders instead of being expanded.Fix
Adds template expansion for
step.Elicitation.MessageinexecuteElicitationStep()before passing it toRequestElicitation(). This mirrors howexecuteToolStep()already expandsstep.Argumentsthrough the template expander (line ~404).The expansion wraps the message string in a temporary map to reuse the existing public
TemplateExpander.Expand()interface, keeping the change minimal and consistent with the established expansion pattern.Testing
TestWorkflowEngine_ElicitationMessageTemplateExpansionintegration test that verifies{{.params.repo}}and{{.params.env}}placeholders in an elicitation message are expanded to their resolved values before reaching the SDK elicitation requester.Happy to address any feedback.
Greetings, saschabuehrle