ROX-23573: Violation 'Image tag' criteria should include image digest when tag is empty#19623
Conversation
|
Skipping CI for Draft Pull Request. |
|
Images are ready for the commit at b3e4845. To use with deploy scripts, first |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #19623 +/- ##
=======================================
Coverage 49.37% 49.37%
=======================================
Files 2743 2743
Lines 207037 207049 +12
=======================================
+ Hits 102223 102238 +15
- Misses 97228 97229 +1
+ Partials 7586 7582 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
clickboo
left a comment
clickboo
left a comment
There was a problem hiding this comment.
Minor comments, also you'll need to rebase to get rid of the Test Bundle failures to get CI green.
| if err != nil { | ||
| return nil, err | ||
| } | ||
| if len(tagMessage) > 0 { |
There was a problem hiding this comment.
imageDetails = append(imageDetails, tagMessage...) - which obviates the need for length check
| Tag string | ||
| Digest string | ||
| } | ||
| tagFields := imageTagDetailFields{} |
There was a problem hiding this comment.
tagFields := imageTagDetailFields {
Tag: imageTag,
Digest: maybeGetSingleValueFromFieldMap(search.ImageSHA.String(), fieldMap)
}
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
charmik-redhat
force-pushed
the
ROX-23573/update-violation-message-for-image-tag-when-it-is-empty
branch
from
3e54607 to
b3e4845
Compare
| Tag: imageTag, | ||
| Digest: maybeGetSingleValueFromFieldMap(search.ImageSHA.String(), fieldMap), | ||
| } | ||
| tagFields.Tag = imageTag |
4 participants
Description
Updates violation message for 'Image tag' criteria to be more clear and include image digest when the tag is empty.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
Manual test
Violation message from a test cluster