feat(stats/base/dists/f/pdf): add native C addon for evaluating the PDF#11201
Open
rautelaKamal wants to merge 1 commit intostdlib-js:developfrom
Open
feat(stats/base/dists/f/pdf): add native C addon for evaluating the PDF#11201rautelaKamal wants to merge 1 commit intostdlib-js:developfrom
rautelaKamal wants to merge 1 commit intostdlib-js:developfrom
Conversation
This adds the missing C-port for the F Distribution Probability Density Function (PDF) taking advantage of standard base math dependencies over N-API.
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Contributor
Author
|
Just a quick heads up regarding the minor coverage drop flagged by Codecov: The native.js file is showing 0% function coverage because the addon.node binary correctly skips compilation during the CI coverage step, which triggers the expected opts.skip = true fallback inside test.native.js. The math logic is fully tested and verified when the native addon actually builds! Also, the drop in ibeta_power_terms.js relates to the original pure JavaScript implementations and was untouched in this PR. @Planeshifter |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #{{TODO: add issue number or delete line if NA}}
Description
This pull request:
@stdlib/stats/base/dists/f/pdf).include.gypi,binding.gyp, andmanifest.jsondependencies via internal N-API mechanisms (STDLIB_MATH_BASE_NAPI_MODULE_DDD_D).NaN.test.native.jsfixtures to validate the C-port accuracy and benchmarks it.Related Issues
This pull request has no related issues.
Questions
No.
Other
This is a Proof of Concept submission towards my GSoC 2026 application regarding porting distributions and specific math functions to high-performance C native addons.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
@stdlib-js/reviewers