Skip to content

bench: refactor to use string interpolation in blas/base/matrix-triangle-resolve-str#11208

Merged
kgryte merged 1 commit intostdlib-js:developfrom
rautelaKamal:bench/blas-base-matrix-triangle-resolve-str-format
Mar 30, 2026
Merged

bench: refactor to use string interpolation in blas/base/matrix-triangle-resolve-str#11208
kgryte merged 1 commit intostdlib-js:developfrom
rautelaKamal:bench/blas-base-matrix-triangle-resolve-str-format

Conversation

@rautelaKamal
Copy link
Copy Markdown
Contributor

Ref: #8647.

Description

What is the purpose of this pull request?

This pull request:

  • Refactors the JavaScript benchmarks in @stdlib/blas/base/matrix-triangle-resolve-str to use string interpolation (@stdlib/string/format) for generating benchmark names instead of string concatenation, as outlined in the tracking issue #8647.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

@stdlib-bot stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review. labels Mar 29, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Mar 29, 2026

Coverage Report

Package Statements Branches Functions Lines
blas/base/matrix-triangle-resolve-str $\color{green}96/96$
$\color{green}+0.00%$
$\color{green}9/9$
$\color{green}+0.00%$
$\color{green}1/1$
$\color{green}+0.00%$
$\color{green}96/96$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

@rautelaKamal rautelaKamal force-pushed the bench/blas-base-matrix-triangle-resolve-str-format branch 4 times, most recently from 381523a to 6849e34 Compare March 29, 2026 21:36
@github-actions github-actions bot mentioned this pull request Mar 30, 2026
@rautelaKamal rautelaKamal force-pushed the bench/blas-base-matrix-triangle-resolve-str-format branch from 6849e34 to e35b9c2 Compare March 30, 2026 04:58
@rautelaKamal rautelaKamal force-pushed the bench/blas-base-matrix-triangle-resolve-str-format branch from e35b9c2 to 74f9840 Compare March 30, 2026 06:26
@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Benchmarks Pull requests adding or improving benchmarks for measuring performance. review: 5 and removed Needs Review A pull request which needs code review. labels Mar 30, 2026
@kgryte kgryte changed the title bench: refactor to use string interpolation in blas/base/matrix-triangle-resolve-str bench: refactor to use string interpolation in blas/base/matrix-triangle-resolve-str Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Benchmarks Pull requests adding or improving benchmarks for measuring performance. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Good First PR A pull request resolving a Good First Issue. review: 5

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants