Skip to content

feat: add blas/base/ndarray/sasum#11215

Merged
kgryte merged 2 commits intostdlib-js:developfrom
MeKaustubh07:blas/ndarray/sasum
Mar 30, 2026
Merged

feat: add blas/base/ndarray/sasum#11215
kgryte merged 2 commits intostdlib-js:developfrom
MeKaustubh07:blas/ndarray/sasum

Conversation

@MeKaustubh07
Copy link
Copy Markdown
Member

Resolves #{{TODO: add issue number}}.

Description

What is the purpose of this pull request?

This pull request:

  • feat: add blas/base/ndarray/sasum

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • #{{TODO: add related issue number}}

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review. labels Mar 30, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Mar 30, 2026

Coverage Report

Package Statements Branches Functions Lines
blas/base/ndarray/sasum $\color{green}101/101$
$\color{green}+0.00%$
$\color{green}3/3$
$\color{green}+0.00%$
$\color{green}1/1$
$\color{green}+0.00%$
$\color{green}101/101$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

@MeKaustubh07
Copy link
Copy Markdown
Member Author

@kgryte, the reason for so many description fixes needed for blas/base/ndarray/dasum was because the blas/base/ndarray/ddot and blas/base/ddot was my primary for reviewing the dasum.
Now that I'm familiar with the description patterns that you have suggested, will follow the path everywhere including this one!

@github-actions github-actions bot mentioned this pull request Mar 30, 2026
@kgryte kgryte added difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. review: 5 Feature Issue or pull request for adding a new feature. and removed Needs Review A pull request which needs code review. labels Mar 30, 2026
Signed-off-by: Athan <kgryte@gmail.com>
Copy link
Copy Markdown
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after clean-up.

@kgryte kgryte merged commit 26bd7e3 into stdlib-js:develop Mar 30, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. review: 4

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants