Skip to content

feat: add stats/incr/nanminabs#5637

Open
rahulrangers wants to merge 6 commits into
stdlib-js:developfrom
rahulrangers:nanminabs
Open

feat: add stats/incr/nanminabs#5637
rahulrangers wants to merge 6 commits into
stdlib-js:developfrom
rahulrangers:nanminabs

Conversation

@rahulrangers
Copy link
Copy Markdown
Contributor

@rahulrangers rahulrangers commented Mar 1, 2025

Resolves #5552

Description

What is the purpose of this pull request?

  • This PR adds the package stats/incr/nanminabs which is a wrapper around stats/incr/minabs to handle NaN values

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@rahulrangers
feat(stats): add @stdlib/stats/incr/nanminabs
953885b 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Mar 1, 2025
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Mar 1, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/incr/nanminabs $\color{green}134/134$
$\color{green}+100.00\%$ 		$\color{green}7/7$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}134/134$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

rahulrangers and others added 5 commits March 2, 2025 01:17
@rahulrangers
Merge branch 'stdlib-js:develop' into nanminabs
787b52a
@rahulrangers
chore: updated dates and package.json
1a6597a 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: passed
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: passed
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: passed
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: passed
---
@rahulrangers
chore: updated package.json
3e6d262 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@rahulrangers
chore: updated package.json
e3b7e4d 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@rahulrangers
chore: updated dates
d83ddbe 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@rahulrangers
Copy link
Copy Markdown
Contributor Author

rahulrangers commented Mar 2, 2025 •
edited
Loading

can you please review @kgryte

@Planeshifter Planeshifter changed the title feat: add @stdlib/stats/incr/nanminabs feat: add stats/incr/nanminabs Jan 14, 2026
Planeshifter
Planeshifter requested changes Mar 10, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for not getting to this for so long... thanks for your PR!

Comment thread lib/node_modules/@stdlib/stats/incr/nanminabs/package.json
@@ -0,0 +1,69 @@
{
"name": "@stdlib/stats/incr/minabs",
Copy link
Copy Markdown
Member

@Planeshifter Planeshifter Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong package name — this is nanminabs, not minabs.

Suggested change
"name": "@stdlib/stats/incr/minabs",
"name": "@stdlib/stats/incr/nanminabs",

Comment thread lib/node_modules/@stdlib/stats/incr/nanminabs/package.json
{
"name": "@stdlib/stats/incr/minabs",
"version": "0.0.0",
"description": "Compute a minimum absolute value incrementally.",
Copy link
Copy Markdown
Member

@Planeshifter Planeshifter Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing "ignoring NaN values" in the description.

Suggested change
"description": "Compute a minimum absolute value incrementally.",
"description": "Compute a minimum absolute value incrementally, ignoring NaN values.",

Comment thread lib/node_modules/@stdlib/stats/incr/nanminabs/examples/index.js
v = ( randu() * 100.0 ) - 50.0;
}
min = accumulator( v );
console.log( '%d\t%d', v.toFixed( 3 ), ( min === null ) ? NaN : min.toFixed( 3 ) );
Copy link
Copy Markdown
Member

@Planeshifter Planeshifter Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.toFixed() returns a string, so %d will strip trailing zeros. Use %s.

Suggested change
console.log( '%d\t%d', v.toFixed( 3 ), ( min === null ) ? NaN : min.toFixed( 3 ) );
console.log( '%s\t%s', ( v !== v ) ? 'NaN' : v.toFixed( 3 ), ( min === null ) ? 'null' : min.toFixed( 3 ) );

@Planeshifter Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 10, 2026
@faisalaffan faisalaffan mentioned this pull request May 22, 2026
Open
5 tasks
@stdlib-bot stdlib-bot added the Potential Duplicate There might be another pull request resolving the same issue. label May 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Planeshifter Planeshifter Planeshifter requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

Good First PR A pull request resolving a Good First Issue. Needs Changes Pull request which needs changes before being merged. Potential Duplicate There might be another pull request resolving the same issue. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: add stats/incr/nanminabs

3 participants

@rahulrangers @stdlib-bot @Planeshifter