Take 2 specification #1
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bordoni
requested changes
Jan 28, 2026
Member
bordoni
left a comment
bordoni
left a comment
There was a problem hiding this comment.
I like where this is headed, potentially lets talk about avoiding non ZIP plugins/themes for now. Let packaging be something the plugin handles.
It prevents complexity from landing on TestFlow.
spec-take-2.md
Outdated
Comment on lines
271
to
286
| ## Plugin/Theme Build Process | ||
|
|
||
| When a repository is cloned, TestFlow executes the following build steps: | ||
|
|
||
| ### Standard Build Steps | ||
| 1. **Initialize git submodules** recursively | ||
| 2. **If `package.json` exists**: Run `nvm use && npm ci && npm run build` | ||
| 3. **If `composer.json` exists**: Run `composer install --no-dev --quiet` | ||
|
|
||
| If any build step fails, TestFlow exits immediately with an error. | ||
|
|
||
| ### Special Case: `common` Directory | ||
| Some repositories (e.g., `the-events-calendar/the-events-calendar`, `the-events-calendar/event-tickets`) contain a `common` directory with shared code. If present: | ||
| 1. Initialize submodules recursively within `common` | ||
| 2. If `common/package.json` exists: Run `nvm use && npm ci && npm run build` in `common` | ||
| 3. If `common/composer.json` exists: Run `composer install --no-dev --quiet` in `common` |
Member
There was a problem hiding this comment.
I would completely skip this step for a initial MVP.
Work only with fully formed ZIPs.
spec-take-2.md
Outdated
| See the `testflow.json` example structure above for full format details. | ||
|
|
||
| ### Source Types | ||
| - **String**: GitHub repository reference (clone) |
Member
There was a problem hiding this comment.
I would rather see a WordPress source than a GitHub Repo.
For github repos, only if it looked for Released ZIPs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only adds a specification file defining the expected code behavior and API.
The specification file is the place where examples of the desired flow, APIs and outcomes are collected.
I'm welcoming feedback to sync on the specification before implementing anything.