fix: ssr issue, move fns inside useEffect#2630
Open
awareness481 wants to merge 1 commit intostreamich:masterfrom
Open
fix: ssr issue, move fns inside useEffect#2630awareness481 wants to merge 1 commit intostreamich:masterfrom
awareness481 wants to merge 1 commit intostreamich:masterfrom
Conversation
awareness481
commented
Apr 12, 2025
| mounted = false; | ||
| navigator.geolocation.clearWatch(watchId); | ||
| }; | ||
| }, []); |
Author
There was a problem hiding this comment.
Ideally, options should be added in the deps array but the changes the behavior of the hook
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The hook as is is not SSR safe (repro: https://ck29z6-3000.csb.app/ ). The timestamp is initialized on the server and on the client as
Date.now()so it's guaranteed to cause a hydration issue when.timestampis used on the DOM (unless the client's clock is behind and by chance it happens to be the same during client rendering).Additionally, there's no point in initializing
.timestampas it arguably should only be initialized/set by the geolocation events.Additional changes include: moving the functions inside useEffect so they're not needed in the deps array, removing
mountedas it's a useless check.Type of change
Checklist
yarn test)yarn lint). Fix it withyarn lint:fixin case of failure.yarn lint:types).