Fix #779: useRaf stop timer fires immediately due to setTimeout overflow#2697
Open
rodionsteshenko wants to merge 1 commit intostreamich:masterfrom
Open
Fix #779: useRaf stop timer fires immediately due to setTimeout overflow#2697rodionsteshenko wants to merge 1 commit intostreamich:masterfrom
rodionsteshenko wants to merge 1 commit intostreamich:masterfrom
Conversation
…mich#779) setTimeout fires immediately when delay exceeds 2^31-1 (2147483647ms). The default ms=1e12 caused the stop timer to fire instantly, breaking the hook. Skip the stop timer for durations exceeding the safe limit. Also fixes the delay test which was inadvertently passing due to the same overflow bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
useRaf's defaultms=1e12overflowssetTimeout's 32-bit integer limit (2^31-1), causing the stop timer to fire immediately. The hook does nothing with default parameters.Fix
Skip the stop timer when
msexceeds2^31-1. Also fixed an existing test that was passing due to the same overflow bug.Test
Added test verifying
useRaf()doesn't jump to elapsed=1 immediately. Full suite: 76 suites, 493 tests pass.Tested locally on macOS ARM (Apple Silicon).