Add SU2.io.fwh: Python reader for FWH binary surface data#2762
Closed
riddhi1228 wants to merge 2 commits intosu2code:developfrom
Closed
Add SU2.io.fwh: Python reader for FWH binary surface data#2762riddhi1228 wants to merge 2 commits intosu2code:developfrom
riddhi1228 wants to merge 2 commits intosu2code:developfrom
Conversation
…weepLib.py string.join() was removed in Python 3. Replace with the equivalent ''.join() syntax. Also removes the now-unused 'import string' statement. Fixes AttributeError: module 'string' has no attribute 'join' when running polar sweep analysis on Python 3.
Member
|
Have you looked at the code changes in this branch by any chance? |
Author
|
Sorry , I opened this PR from the wrong branch. The branch has an unrelated commit that was already merged in #2760. I'll close this and reopen from the correct branch with the actual FWH reader code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Adds
SU2.io.fwhmodule with a pure-Python reader for the FWH binary surface data format used by SU2PY_FWH. The reference fileTestCases/unsteady/square_cylinder/fwh_bin.dathad no corresponding Python reader in the repository.Related Work
Related to the SU2PY_FWH aeroacoustics post-processor. No related PRs.
PR Checklist