Skip to content

Conversation

@TanmayBansa1
Copy link
Contributor


name: Added hyperlinks to content in TryNow pages
about: links added to the constants' data for TryNow pages

Description

Added links to the content section of the constants data for the respective pages, modified the Paragraph and StepsToUse components to handle the rendering of links using the dompurify library, created a utils file containing a function to handle the link rendering

Related Issue

Fixes #73

##Before
image

##After
image

Changes Made

  • Change 1 -> added links to the data stored in constants folder for TryNow pages
  • Change 2 -> created a separate utils file called renderlinks-utils to render links on the UI
  • Change 3 -> modified the Paragraph and StepsToUse components to handle the input of links as a part of the props,
    and then render the links using the compurify library.
  • Change 4 -> modified the MusicBlocks, TurtleBlocks, Raspberry pages in the TryNow section to handle links as input from the constants' data

Testing Performed

  • Ran npm run lint:ts.
  • Ran npm run format:file for all the files that I have changed.
  • Tested on browsers Edge, Brave, Arc, Chrome.
  • Verified in the end by running npm run build.

Checklist

  • I have tested these changes locally and they work as expected.
  • I have added/updated tests that prove the effectiveness of these changes.
  • I have updated the documentation to reflect these changes, if applicable.
  • I have followed the project's coding style guidelines.
  • I have addressed the code review feedback from the previous submission, if applicable.

Thank you for contributing to our project! We appreciate your help in improving it.

📚 See contributing instructions.

🙋🏾🙋🏼 Questions: Community Matrix Server.

@FirePheonix
Copy link
Contributor

@TanmayBansa1 .
Make sure you add the links to all of them. Me and safwan will look into if using dangerouslyHTML gets us in some issues related to future development. Otherwise, amazing job done.

@TanmayBansa1
Copy link
Contributor Author

TanmayBansa1 commented Mar 24, 2025

@FirePheonix I have added links to all the TryNow pages by verifying them against the v1 of the website. Thank you for reviewing.

@FirePheonix
Copy link
Contributor

FirePheonix commented Mar 25, 2025

@TanmayBansa1 Yess.
Don't close this PR as of now, just let it be for now, we'll soon review and merge it.

@sa-fw-an sa-fw-an merged commit 1fe19ff into sugarlabs:main Mar 26, 2025
2 checks passed
@TanmayBansa1 TanmayBansa1 deleted the adding-hyperlinks-to-trynow branch April 27, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Hyperlinks to TryNow pages

3 participants