chore(cli): track output_format and fix is_agent CI parity#5513
Open
pamelachia wants to merge 2 commits into
Open
chore(cli): track output_format and fix is_agent CI parity#5513pamelachia wants to merge 2 commits into
pamelachia wants to merge 2 commits into
Conversation
Coverage Report for CI Build 27151276534Coverage decreased (-0.03%) to 64.287%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions31 previously-covered lines in 4 files lost coverage.
Coverage Stats
💛 - Coveralls |
Supabase CLI previewnpx --yes https://pkg.pr.new/supabase@5513Preview package for commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an
output_formatproperty to thecli_command_executedtelemetry event and fixes a Go/TS divergence in howis_agentis computed. Together these make the JSON-vs-human output choice measurable and ensure both CLI shells agree on what counts as an agent. This is the measurement-and-parity groundwork for auto-switching agents to JSON output (next subissue under GROWTH-806).Changes
cli_command_executed. Addedoutput_formatto the Go catalog (events.go) and its TS mirror (event-catalog.ts), and emit it from the Go capture and both TS instrumentation paths.db queryresolves its format into a command-local flag, so it now mirrors the resolved value onto the global that telemetry reads, keeping the value accurate for the highest-volume agent command. The property does not exist today, so current JSON usage is unmeasurable without it.is_agentGo/TS parity. The TS legacy analytics layer folded CI intois_agent(is_agent = aiTool || isCi), tagging CI environments as agents while the Go binary does not.is_agentnow reflects coding-agent detection only, matching Go on both shells.is_cicontinues to be reported as its own separate property.Notes for reviewers
output_formatvalues are shell-native (Go:pretty|json|yaml|toml|env; TS:text|json|stream-json), disambiguated by$lib; normalize in analysis.runtime.isCigates behavior inlegacy-platform-api.layer.ts, so changing those lists would alter non-interactive behavior for some CI environments. That belongs in a separate change, not this telemetry-parity fix.Outputbecause the instrumentation readsoutput.format.Linear