fix(typegen): omit generated columns from Insert and Update types - #1104
Closed
daviddallakyan2005 wants to merge 2 commits into
Closed
fix(typegen): omit generated columns from Insert and Update types#1104daviddallakyan2005 wants to merge 2 commits into
daviddallakyan2005 wants to merge 2 commits into
Conversation
Stored GENERATED columns are not writable, but TypeScript typegen only excluded identity-ALWAYS columns. Treat is_generated the same way. Co-authored-by: Cursor <cursoragent@cursor.com>
daviddallakyan2005
requested review from
a team,
avallete and
soedirgo
as code owners
August 14, 2026 21:40
Co-authored-by: Cursor <cursoragent@cursor.com>
Author
|
Closing to replace with a single-commit PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #838
Stored
GENERATED ALWAYS AS … STOREDcolumns are not writable, but TypeScript typegen only excluded identity-ALWAYS columns.is_generatedis already populated by column introspection; Insert/Update now treat it the same way and emitfield?: never, while the column remains on Row. Go, Swift, and Python generators are separate and still include generated columns — this PR is TypeScript-only.How to test
npm install npm testnpm teststarts Postgres viatest/db/docker-compose.yml(Docker required) and runs Vitest. Use Node 22 (.nvmrc). The new assertion istypegen: typescript omits generated columns from Insert and Updateagainst fixture tablepublic.people.