fix(setup-postgres.yml): fix missing initdb calls #1924
Conversation
|
✅ Tested pause/restore on local infra with ⏱️ Pending upgrade test |
There was a problem hiding this comment.
Pull request overview
This PR adds the --data-checksums flag to PostgreSQL initdb commands in the Ansible playbook to enable data page checksums for data corruption detection.
Key Changes:
- Added
--data-checksumsflag to both initdb command variations (standard and ICU locale-enabled)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hunleyd
left a comment
hunleyd
left a comment
There was a problem hiding this comment.
i think you also need to adjust some additional files like ansible/files/admin_api_scripts/pg_upgrade_scripts/initiate.sh, nix/init.sh, nix/docker/init.sh.in, nix/checks.nix. There are potentially others found by using rg initdb at the top of the repo. @samrose can probably confirm if the others need altered once you have a complete list
What kind of change does this PR introduce?
updates initdb calls with checksum flag
What is the current behavior?
missing calls from ansible playbook with checksum flag
What is the new behavior?
updated initdb flags for checksums
Additional context
none