Update supautils.conf.j2 | allow users to update hsnw settings#1994
Update supautils.conf.j2 | allow users to update hsnw settings#1994TheOtherBrian1 wants to merge 3 commits intodevelopfrom
Conversation
WalkthroughUpdated the PostgreSQL supautils configuration: Changes
Sequence Diagram(s)(Skipped — change is a small config update that does not alter control flow or introduce multi-component interactions.) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: Repository UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
ansible/files/postgresql_config/supautils.conf.j2
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
- GitHub Check: run-check-harness-psql-orioledb-17 (aarch64-linux)
- GitHub Check: run-check-harness-psql-15 (aarch64-linux)
- GitHub Check: treefmt-check (aarch64-linux)
- GitHub Check: run-check-harness-psql-17 (aarch64-linux)
- GitHub Check: pre-commit-run (aarch64-linux)
- GitHub Check: run-check-harness-psql-15 (aarch64-darwin)
- GitHub Check: nix-shell (x86_64-linux)
- GitHub Check: run-check-harness-psql-17 (x86_64-linux)
- GitHub Check: run-check-harness-psql-15 (x86_64-linux)
- GitHub Check: run-check-harness-psql-orioledb-17 (x86_64-linux)
samrose
left a comment
There was a problem hiding this comment.
Need thorough review before merge
|
From the ticket:
I would've expected the error to be something along the lines of "permission denied to configure ..."; "unrecognized configuration parameter" seems to imply the library was not loaded at all. @pashkinelfe can you confirm if that's the case and if these configs are meant to be user-configurable? |
What kind of change does this PR introduce?
Feature
What is the current behavior?
Users cannot update the pg_vector settings:
at the ROLE level
What is the new behavior?
Allow users to change these values at the role level
Additional context
User asked to be granted these permissions:
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.