Skip to content

Fix: enable safeupdate for Data API #2105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
encima wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix: enable safeupdate for Data API #2105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b82b3f1
enable safeupdate for anon, authenticator and authenticator roles by …
encima Apr 3, 2026
85247b5
fix: update oriole tests for roles
encima Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions migrations/db/migrations/20260403172611_safeupdate-data-api-enable.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
-- migrate:up
ALTER ROLE anon SET local_preload_libraries = '$libdir/plugins/safeupdate';
ALTER ROLE authenticator SET local_preload_libraries = '$libdir/plugins/safeupdate';
ALTER ROLE authenticated SET local_preload_libraries = '$libdir/plugins/safeupdate';
ALTER ROLE authenticator RESET session_preload_libraries;
ALTER ROLE postgres SET local_preload_libraries = '$libdir/plugins/safeupdate';

ALTER ROLE anon SET safeupdate.enabled = 1;
ALTER ROLE authenticator SET safeupdate.enabled = 1;
ALTER ROLE authenticated SET safeupdate.enabled = 1;
ALTER ROLE postgres SET safeupdate.enabled = 0;


-- migrate:down

12 changes: 6 additions & 6 deletions nix/ext/pg-safeupdate.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ let
runHook preInstall

mkdir -p $out/share/postgresql/extension

mkdir -p $out/lib/plugins
# Install versioned library
install -Dm755 ${pname}${postgresql.dlSuffix} $out/lib/${pname}-${version}${postgresql.dlSuffix}
install -Dm755 ${pname}${postgresql.dlSuffix} $out/lib/plugins/${pname}-${version}${postgresql.dlSuffix}

runHook postInstall
'';
Expand Down Expand Up @@ -64,15 +64,15 @@ pkgs.buildEnv {
paths = packages;
nativeBuildInputs = [ makeWrapper ];
pathsToLink = [
"/lib"
"/lib/plugins"
"/share/postgresql/extension"
];
postBuild = ''
ln -sfn ${pname}-${latestVersion}${postgresql.dlSuffix} $out/lib/${pname}${postgresql.dlSuffix}
ln -sfn ${pname}-${latestVersion}${postgresql.dlSuffix} $out/lib/plugins/${pname}${postgresql.dlSuffix}

# checks
(set -x
test "$(ls -A $out/lib/${pname}*${postgresql.dlSuffix} | wc -l)" = "${
test "$(ls -A $out/lib/plugins/${pname}*${postgresql.dlSuffix} | wc -l)" = "${
toString (numberOfVersionsBuilt + 1)
}"
)
Expand All @@ -83,7 +83,7 @@ pkgs.buildEnv {
numberOfVersions = numberOfVersionsBuilt;
inherit pname latestOnly;
defaultSettings = {
shared_preload_libraries = [ "safeupdate" ];
local_preload_libraries = [ "safeupdate" ];
};
pgRegressTestName = "pg-safeupdate";
version =
Expand Down
2 changes: 1 addition & 1 deletion nix/tests/expected/pg-safeupdate.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
load 'safeupdate';
load '$libdir/plugins/safeupdate';
set safeupdate.enabled=1;
create schema v;
create table v.foo(
Expand Down
12 changes: 6 additions & 6 deletions nix/tests/expected/roles.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,11 @@ select
from pg_roles r
where rolname not in ('pg_create_subscription', 'pg_maintain', 'pg_use_reserved_connections')
order by rolname;
rolname | rolconfig
----------------------------+---------------------------------------------------------------------------------
anon | {statement_timeout=3s}
authenticated | {statement_timeout=8s}
authenticator | {session_preload_libraries=safeupdate,statement_timeout=8s,lock_timeout=8s}
rolname | rolconfig
----------------------------+-------------------------------------------------------------------------------------------------------------------------------
anon | {statement_timeout=3s,"local_preload_libraries=\"$libdir/plugins/safeupdate\"",safeupdate.enabled=1}
authenticated | {statement_timeout=8s,"local_preload_libraries=\"$libdir/plugins/safeupdate\"",safeupdate.enabled=1}
authenticator | {statement_timeout=8s,lock_timeout=8s,"local_preload_libraries=\"$libdir/plugins/safeupdate\"",safeupdate.enabled=1}
dashboard_user |
pg_checkpoint |
pg_database_owner |
Expand All @@ -83,7 +83,7 @@ order by rolname;
pgsodium_keyiduser |
pgsodium_keymaker |
pgtle_admin |
postgres | {"search_path=\"\\$user\", public, extensions"}
postgres | {"search_path=\"\\$user\", public, extensions","local_preload_libraries=\"$libdir/plugins/safeupdate\"",safeupdate.enabled=0}
service_role |
supabase_admin | {"search_path=\"$user\", public, auth, extensions",log_statement=none}
supabase_auth_admin | {search_path=auth,idle_in_transaction_session_timeout=60000,log_statement=none}
Expand Down
12 changes: 6 additions & 6 deletions nix/tests/expected/z_multigres-orioledb-17_roles.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,11 @@ select
from pg_roles r
where rolname not in ('pg_create_subscription', 'pg_maintain', 'pg_use_reserved_connections')
order by rolname;
rolname | rolconfig
----------------------------+---------------------------------------------------------------------------------
anon | {statement_timeout=3s}
authenticated | {statement_timeout=8s}
authenticator | {session_preload_libraries=safeupdate,statement_timeout=8s,lock_timeout=8s}
rolname | rolconfig
----------------------------+-------------------------------------------------------------------------------------------------------------------------------
anon | {statement_timeout=3s,"local_preload_libraries=\"$libdir/plugins/safeupdate\"",safeupdate.enabled=1}
authenticated | {statement_timeout=8s,"local_preload_libraries=\"$libdir/plugins/safeupdate\"",safeupdate.enabled=1}
authenticator | {statement_timeout=8s,lock_timeout=8s,"local_preload_libraries=\"$libdir/plugins/safeupdate\"",safeupdate.enabled=1}
dashboard_user |
pg_checkpoint |
pg_database_owner |
Expand All @@ -77,7 +77,7 @@ order by rolname;
pg_write_server_files |
pgbouncer |
pgtle_admin |
postgres | {"search_path=\"\\$user\", public, extensions"}
postgres | {"search_path=\"\\$user\", public, extensions","local_preload_libraries=\"$libdir/plugins/safeupdate\"",safeupdate.enabled=0}
service_role |
supabase_admin | {"search_path=\"\\$user\", public, auth, extensions",log_statement=none}
supabase_auth_admin | {search_path=auth,idle_in_transaction_session_timeout=60000,log_statement=none}
Expand Down
2 changes: 1 addition & 1 deletion nix/tests/sql/pg-safeupdate.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
load 'safeupdate';
load '$libdir/plugins/safeupdate';

set safeupdate.enabled=1;

Expand Down
Loading