fix: keep config operations on the selected file#57
Open
z116123123x wants to merge 1 commit into
Open
Conversation
4005f9f to
ddaf0c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Runtime loading checks
supermemory.jsoncbeforesupermemory.json, but installand status previously used
supermemory.jsonunconditionally. With only JSONCpresent, install could therefore create a second JSON file with conflicting
defaults while the runtime continued reading JSONC.
This keeps the existing precedence and fresh-install JSON default. Existing
JSONC is updated without reserializing its existing content: missing top-level
defaults are inserted, the candidate is reparsed and checked against every
prior value before writing, and the original remainder of the file is preserved
byte-for-byte. No new runtime dependency is introduced.
Validation
bun install --frozen-lockfilebun test(22 tests, 150 assertions)bun run typecheckbun run buildgit diff --checkAll checks pass. The status test stubs
fetch; no external provider call ismade.