Skip to content

convex integration with supermemory#880

Open
sreedharsreeram wants to merge 3 commits intomainfrom
convex-docs
Open

convex integration with supermemory#880
sreedharsreeram wants to merge 3 commits intomainfrom
convex-docs

Conversation

@sreedharsreeram
Copy link
Copy Markdown
Member

No description provided.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Apr 23, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
supermemory-app e8c79b4 Commit Preview URL

Branch Preview URL
May 09 2026, 07:17 PM

@mintlify
Copy link
Copy Markdown
Contributor

mintlify Bot commented Apr 23, 2026

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
supermemory 🟢 Ready View Preview Apr 23, 2026, 5:48 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

Copy link
Copy Markdown
Member Author


How to use the Graphite Merge Queue

Add the label Main to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Copy Markdown
Contributor

@vorflux vorflux Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — found 2 issues in the documentation examples.


Review with Vorflux

Comment thread apps/docs/integrations/convex.mdx
Comment thread apps/docs/integrations/convex.mdx
@sreedharsreeram sreedharsreeram marked this pull request as ready for review April 24, 2026 19:12
@sreedharsreeram sreedharsreeram requested a review from Dhravya April 24, 2026 19:12
@claude
Copy link
Copy Markdown

claude Bot commented Apr 24, 2026

Claude finished @sreedharsreeram's task in 1m 26s —— View job


Reviewing PR #880: Convex Integration Documentation

  • Fetching PR diff and existing review comments
  • Analyzing code examples for correctness
  • Checking against existing AI SDK documentation patterns
  • Submitting review

Summary

Documentation looks good to ship. All issues from previous reviews have been addressed:

Issue Status
withSupermemory signature ✓ Fixed — now uses (model, options) with containerTag and customId
Missing AI SDK packages install ✓ Fixed — added separate install step
Missing api import ✓ Fixed — import added
Partial failure note ✓ Fixed — comment added

Score: 9/10 — Ready to merge.

Copy link
Copy Markdown
Contributor

@vorflux vorflux Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation-only PR for Convex integration. The structure and content are solid overall, but there are a few issues -- most critically, the withSupermemory call in the AI SDK chat example uses the wrong function signature.

Comment thread apps/docs/integrations/convex.mdx
Comment thread apps/docs/integrations/convex.mdx
Comment thread apps/docs/integrations/convex.mdx
Comment thread apps/docs/integrations/convex.mdx
Comment thread apps/docs/integrations/convex.mdx
Comment thread apps/docs/integrations/convex.mdx
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 9, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
supermemory-mcp e8c79b4 May 09 2026, 07:15 PM

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview: Adds Convex integration documentation with code examples for basic memory operations and AI SDK middleware usage.

Issues found: None — the previous review feedback has been addressed:

  • withSupermemory now uses the correct signature with containerTag and customId inside the options object (verified against packages/tools/src/vercel/index.ts:111)
  • ✓ AI SDK packages install step has been added
  • ✓ The api import is now included in the dual-store example
  • ✓ A note about partial failure handling has been added

The code examples are consistent with the existing AI SDK documentation patterns.

Score: 9/10

Minor polish opportunity (not blocking): the intro line could be softened as suggested in the earlier review, but that's purely editorial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant