Skip to content

Conversation

@ovitrif
Copy link
Collaborator

@ovitrif ovitrif commented Jan 14, 2026

Note

Part of PR stack together with:

Description

This PR:

  1. Adds dynamic boost fee time confirmation estimates
    • Although the UI will likely always show the same estimate as the hardcoded ones used before this implementation. This happens because fee rates values are almost always corresponding to the previously hardcoded confirmation time estimate.
  2. Implements weather widget API response caching
  3. Cleans up deprecated code, warnings, and TODOs across the codebase
  4. Fixes all custom error types to use class instead of data class or data object
  5. Adds context to logs where it was missing
  6. Refactors most try/catch statements to runCatching
  7. Restructures Env constants
  8. Replaces deprecated MainUiState aggregate model with direct use of the separated node & wallet states exposed via wallet viewmodel
  9. Simplifies lightning service by removing redundant state management
  10. Removes deprecated migration test
  11. Remove completed TODOs and fixes or suppresses remaining ones
  12. Updates AGP & adds compose-stability-analyzer plugin
  13. Clears detekt-baseline by either fixing or suppressing all lint warnings inline
  14. Updates README and docs to:
  • list recommended IDE plugins with setup guide
  • communicates the correct paths to save the google-services.json files for each build flavor group: mainnetRelease for PROD and the STAG one for the rest
  1. Captures and cancels the job handling the LDK event listener(s)
  2. Fixes toast blur on wallet restore error screen
  3. Refactors state for restore retry and replaces blind node start with restart in the button callback
  4. Removes logs reset on wallet wipe by conditioning it only for debug builds
  5. Adds reset logs to dev settings screen

Preview

N/A

QA Notes

Regression Tests:

  • Test boost fee time estimates shows "±10 min" (not hardcoded but still most likely)
  • Test Weather widget updates (check logs)
  • Test unconfirmed transactions time estimates formatting (⚠️ refactored)
  • Test receive sheet + receive → edit screen & state (⚠️ refactored underlying state)

@ovitrif ovitrif changed the title chore: fix all warnings and code cleanup fix: compiler warnings and code patterns Jan 14, 2026
@claude

This comment has been minimized.

@ovitrif ovitrif self-assigned this Jan 14, 2026
@claude

This comment has been minimized.

@claude

This comment has been minimized.

@claude

This comment has been minimized.

@claude

This comment has been minimized.

@claude

This comment has been minimized.

@claude

This comment has been minimized.

Base automatically changed from chore/i18n-localization to master January 15, 2026 02:51
@claude

This comment has been minimized.

@ovitrif ovitrif enabled auto-merge January 15, 2026 05:06
@claude

This comment has been minimized.

@claude

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants