Merged
Conversation
- Change Routes.ChannelDetail to accept channelId parameter - Update ChannelDetailScreen to fetch channel on initialization - Replace early return with loading state when channel is null - Navigate directly to detail screen with channelId - Remove intermediate navigation through list screen - Fix predictive back gesture by eliminating blank composable state Fixes #668 Co-authored-by: Ovi Trif <ovitrif@users.noreply.github.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
app/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
Show resolved
Hide resolved
app/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailScreen.kt
Show resolved
Hide resolved
app/src/main/java/to/bitkit/ui/settings/lightning/CloseConnectionViewModel.kt
Show resolved
Hide resolved
ovitrif
changed the title
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ovitrif
force-pushed
the
fix/channel-screen-nav-668
branch
from
a7fe03a to
20eb8f5
Compare
app/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/to/bitkit/ui/settings/lightning/CloseConnectionViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/to/bitkit/ui/settings/lightning/LightningConnectionsViewModel.kt
Outdated
Show resolved
Hide resolved
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Author
|
@claude Summarize the changes for reviewers. |
This comment has been minimized.
This comment has been minimized.
app/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
Show resolved
Hide resolved
app/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailScreen.kt
Show resolved
Hide resolved
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
app/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
Show resolved
Hide resolved
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
piotr-iohk
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #668
This PR:
ChannelDetailViewModelandCloseConnectionViewModelfrom the monolithicLightningConnectionsViewModelDescription
The channel detail and close connection screens previously depended on a shared parent ViewModel (
LightningConnectionsViewModel) to hold the selected channel state. This caused black screens when navigating back and forth, since the shared state could be lost during back-stack restoration or recomposition.The fix converts
Routes.ChannelDetailandRoutes.CloseConnectionfromdata objecttodata classwith achannelIdparameter, making each screen self-contained. Each screen now has its own ViewModel that loads channel data independently using the passed ID.Additional improvements:
Preview
before_1.75x.mp4
after_1.75x.mp4
QA Notes
Tests
Regression Tests (pick a few randomly)