Open
Conversation
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Drafted to implement the new "camera disabled" design |
Member
Author
I'll do it in other branch to don't make the PR too big |
app/src/main/java/to/bitkit/ui/screens/settings/ProbingToolScreen.kt
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
Author
|
drafted to investigate e2e failure |
Member
Author
|
@piotr-iohk I see "127.0.0.1:6001:s" on the input of this test. Is it expected? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIGMA
This PR converts the QR scanner from a full-screen navigation route into a proper bottom sheet, consistent with other sheets in the app (Send, Receive, Backup, etc).
Description
NavControllerdependency fromQrScanningScreenand simplifies it to acceptonBack/onScanSuccesscallbacksQrScanningSheetthat wraps the scanner in aSheetHost-compatible composable withsheetHeight()Sheet.QrScannertype and result routing viaAppViewModel.showScannerSheet(onResult)Routes.QrScannernavigation route andnavigateToScanner()extensioninSheetconditional styling from scanner and camera permission views, always using sheet stylingPreview
normal-payment.mp4
send-sheet.mp4
probing.mp4
quickpay.mp4
QA Notes
Tab bar scanner
Send sheet scanner
Settings screens (for-result pattern)
Camera permission denied
Gallery and paste