Skip to content

fix: public payments polish#933

Merged
ovitrif merged 4 commits intomasterfrom
codex/fix-public-payments-polish
May 6, 2026
Merged

fix: public payments polish#933
ovitrif merged 4 commits intomasterfrom
codex/fix-public-payments-polish

Conversation

@ben-kaufman
Copy link
Copy Markdown
Contributor

Fixes #931

Description

Polishes the public contact payment flows from PR #924:

  • Routes Pubky keys entered manually through the same contact/profile resolution used by paste and scan.
  • Pops the Add Contact screen before opening the payment flow, avoiding the background Add Contact screen glitch.
  • Preserves contact metadata on RBF replacement transactions and filters replaced sent transactions from contact activity.
  • Shares the replaced-sent-transaction predicate through the existing activity extension layer.

Preview

N/A

QA Notes

Validated with:

  • ./gradlew testDevDebugUnitTest --tests "to.bitkit.repositories.ActivityRepoTest" --tests "to.bitkit.viewmodels.AppViewModelSendFlowTest"
  • ./gradlew compileDevDebugKotlin
  • ./gradlew testDevDebugUnitTest
  • ./gradlew detekt

Suggested manual checks:

  • Send -> Enter manually with a Pubky key routes to the expected contact/profile flow.
  • Paying a contact from Add Contact opens the send flow without leaving Add Contact visible behind it.
  • RBF a sent contact transaction and confirm contact activity shows the replacement transaction rather than the removed mempool transaction.

@ben-kaufman ben-kaufman marked this pull request as ready for review May 6, 2026 01:53
@claude

This comment has been minimized.

@piotr-iohk
Copy link
Copy Markdown
Collaborator

Tested. Seeing two out of three original issues:

  • Send -> Enter manually with a Pubky key routes to the expected contact/profile flow. ❌
  • Paying a contact from Add Contact opens the send flow without leaving Add Contact visible behind it. ❌
Screen.Recording.2026-05-06.at.09.04.59.mov

  • RBF a sent contact transaction and confirm contact activity shows the replacement transaction rather than the removed mempool transaction. ✅
Screenshot 2026-05-06 at 09 06 32

Copy link
Copy Markdown
Collaborator

@piotr-iohk piotr-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still seeing two issues.

Base automatically changed from codex-public-payments-contacts to master May 6, 2026 08:30
@ovitrif ovitrif added this to the 2.3.0 milestone May 6, 2026
@ovitrif ovitrif changed the title [codex] fix public payments polish fix: public payments polish May 6, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e240518642

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread app/src/main/java/to/bitkit/services/CoreService.kt
@ben-kaufman ben-kaufman force-pushed the codex/fix-public-payments-polish branch from 670a4e7 to 17c7256 Compare May 6, 2026 13:07
Copy link
Copy Markdown
Collaborator

@piotr-iohk piotr-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Issues fixed.

Copy link
Copy Markdown
Collaborator

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

Tested:

  • Send → Scan → Pay
  • Send → Paste → Pay
  • Send → Enter Manually → Paste → Pay
  • QR → Scan → Pay
  • QR → Paste button → Pay
  • Pay to contact → RBF Boost → Contact Activity List

@ovitrif ovitrif merged commit e39c878 into master May 6, 2026
18 of 19 checks passed
@ovitrif ovitrif deleted the codex/fix-public-payments-polish branch May 6, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Public payments polish

3 participants