fix: require android dwarf symbols#100
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b2b1672891
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (sectionsExit != 0 || !Regex("""\.debug_""").containsMatchIn(sections)) { | ||
| throw GradleException("Android native library has no full DWARF debug metadata: '${lib.path}'") |
There was a problem hiding this comment.
This predicate still passes artifacts that only contain a partial DWARF section, e.g. a line-tables-only build with .debug_line/.debug_line_str but no .debug_info. In that case the publish gate would accept a library that does not contain the full DWARF metadata this change is meant to require; the shell validator was changed to the same broad \.debug_ test, so both gates should check for the section(s) that prove full debug info is present, at least .debug_info.
Useful? React with 👍 / 👎.
1 participant
Refs synonymdev/bitkit-android#982
Related
Description
Follow-up to #99. The Android release path now requires full DWARF
.debug_*sections instead of accepting symbol-table-only metadata.This PR:
0.1.71.Package.swiftchecksum for the same release version.libbitkitcore.sofiles exceed GitHub's normal blob limit and this repo has Git LFS disabled.Release
Pending after PR creation:
v0.1.71com.synonym:bitkit-core-android:0.1.71Preview
N/A
QA Notes
./build.sh -r all.bash -n build_android.sh../bindings/android/gradlew --project-dir ./bindings/android :lib:validateReleaseNativeLibrariesafter regeneration.cargo fmt --check.git diff --check..debug_*sections and0x4000LOAD alignment.