[codex] Add public Paykit payments to contacts#531
Conversation
1d622bc to
18a0af9
Compare
18a0af9 to
f1a122e
Compare
This comment has been minimized.
This comment has been minimized.
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
5b94276 to
3d1f2b2
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3ea3f5832a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Tested roughly against this plan. Tested against staging. Areas tested and 🟢 for me (encountered issue #536, but seems unrelated to paykit).
Some testing notes / observations:
|
piotr-iohk
left a comment
There was a problem hiding this comment.
LGTM, remaining obesrvations can be addressed separately, issue for tracking: #539
ovitrif
left a comment
There was a problem hiding this comment.
LGTM
Tested using same script like on Android counterpart ([codex] add public contact payments).
Focused on validating, besides happy flow, edge cases to ensure Public pay2contact payment methods are always up-to-date.
ovitrif
left a comment
There was a problem hiding this comment.
Validated fix in last commit for Payky 🎉
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 768c3d05a8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
I checked 2881537. It seems to only partially touch #539 (not sure if that was the intent): it filters replaced RBFd sent transactions from contact activity, so it removes the stale “Removed from Mempool” row, but it doesn't make the new replacement tx appear in contact activity - effectively RBFd tx does not appear in the activity at all. The manual Send -> Enter manually pubky routing is not addressed by this commit. |
|
Aside from things already mentioned I noted the following: Missing or disabled UI (make sure this was left out of scope on purpose):
Pay to contact (LN, iOS to iOS): For a new profile, when creating the first channel it publishes an invoice, but it does not seem to be payable (route not found). Only after a restart (receiver) can it be paid.
Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2026-05-06.at.12.59.39.movUI in general needs a lot of polishing, but out of scope for this PR. |
|
Updated issue for polishing work 539 with @pwltr 's findings: |


Summary
Notes
Validation
swiftformaton touched Swift filesgit diff --checkxcodebuild -resolvePackageDependencies -project Bitkit.xcodeprojvss-rust-client-ffigenerated bindings.globdependency.