chore: speed up bindings generation pipeline#71
Merged
Conversation
…tion Add `debug = "line-tables-only"` to the `release-smaller` Cargo profile so Xcode can generate dSYM files for LDKNodeFFI and Android builds include DWARF info for crash symbolication. Bumps version to 0.7.0-rc.31. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ovitrif
changed the title
2 tasks
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ovitrif
force-pushed
the
fix/dsym-debug-symbols
branch
from
011a4cf to
f045195
Compare
ben-kaufman
reviewed
Mar 3, 2026
ben-kaufman
reviewed
Mar 3, 2026
Ensures debug symbols are bundled into a single .dSYM (macOS) or embedded DWARF (Linux) rather than scattered across object files. Addresses PR #71 review feedback. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
fix: prevent cumulative change-address index leak in dry-run tx builds
This comment was marked as resolved.
This comment was marked as resolved.
The debug/split-debuginfo settings added in #71 doubled the XCFramework zip size (239→479 MB). Remove them entirely and revert version from rc.32 back to rc.31. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ovitrif
changed the title
- Replace individual binding scripts with single `./bindgen.sh` entry point - Clarify CHANGELOG is cumulative; point to PR Release Workflow for release notes - Add critical rules: commit before tagging, delta-only release notes Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The code-review plugin defaults to terminal output without --comment, so reviews were silently discarded in CI. Additionally, Bash commands (gh CLI, git) are not auto-allowed by the action and need explicit --allowedTools to function. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Releases must be published (not draft) and set as latest - Release notes are for binding consumers only — no internal CI/docs/workflow changes Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Bust Android CI cache after rc.31 retag. Update bindgen rule to allow background execution. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ben-kaufman
approved these changes
Mar 5, 2026
pwltr
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cancel_tx/cancel_dry_run_txon all early-return and fee-estimation paths./bindgen.sh: remove irrelevantcargo buildfor debug symbols that wasrunning a full host build before the actual cross-compilation, eliminate duplicate
gobley-uniffi-bindgeninstall, standardize all targets onrelease-smallerwhen running as code-review plugin in GitHub Actions (
AGENTS.md)--commentflagand
--allowedToolsfor Bash/gh CLI (reviews were silently discarded since inception)v0.7.0-rc.32, update all bindingsBuild time perf
Got the 1st full
./bindgen.shbuild on M1 Mac ~32% faster.Test plan
./bindgen.shcompletes successfully on macOScargo testpasses (including newcancel_dry_run_txtests inbdk-wallet-aggregate)Package.swiftmatches built artifactRelease
Integration