Skip to content

Fix #435: add --role/-r to creategroup - #447

Open
jacalata wants to merge 1 commit into
developmentfrom
jac/435-creategroup-role
Open

Fix #435: add --role/-r to creategroup#447
jacalata wants to merge 1 commit into
developmentfrom
jac/435-creategroup-role

Conversation

@jacalata

@jacalata jacalata commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • tabcmd Classic accepts --role/-r on creategroup to set a default site role for the group; users added later without an explicit role inherit that default.
  • tabcmd 2 was missing the flag, so groups always got created with no minimum_site_role.
  • Reuse UserCommand.set_role_arg for the same choices and case-insensitive parsing used by other user commands, and set GroupItem.minimum_site_role before server.groups.create when the flag is supplied. TSC handles the wire XML.

Closes #435.

Test plan

  • tests/parsers/test_parser_create_group.py — 4 new tests cover --role Viewer, -r Explorer, case-insensitive creator -> Creator, and flag-optional
  • Full test_parser_create_group.py suite: 6 passed

🤖 Generated with Claude Code

tabcmd Classic accepts a default site role for the group at creation
time via --role/-r; users added later without an explicit role inherit
this default. tabcmd 2 was missing the flag, so groups were always
created with no minimum_site_role.

Reuse UserCommand.set_role_arg for the same choices and
case-insensitive parsing that createsiteusers/removeusers use, and set
GroupItem.minimum_site_role before calling groups.create when the flag
was supplied. TSC handles the wire-format via update_req().

Fixes #435.
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

Coverage

Coverage Report
FileStmtsMissCoverMissing
tabcmd
   __main__.py121212 0%
   _version.py111111 0%
   tabcmd.py151515 0%
   version.py955 44%
tabcmd/commands
   commands.py101010 0%
   constants.py771818 77%
   server.py1351818 87%
tabcmd/commands/auth
   session.py3945050 87%
tabcmd/commands/datasources_and_workbooks
   datasources_and_workbooks_command.py1571818 89%
   datasources_workbooks_views_url_parser.py14255 96%
   delete_command.py601616 73%
   export_command.py1202525 79%
   get_url_command.py1274747 63%
   publish_command.py1232828 77%
   runschedule_command.py2177 67%
tabcmd/commands/extracts
   create_extracts_command.py4288 81%
   decrypt_extracts_command.py2722 93%
   delete_extracts_command.py3766 84%
   encrypt_extracts_command.py2722 93%
   extracts.py2022 90%
   reencrypt_extracts_command.py2722 93%
   refresh_extracts_command.py481010 79%
tabcmd/commands/group
   create_group_command.py3366 82%
   delete_group_command.py2722 93%
tabcmd/commands/project
   create_project_command.py4688 83%
   delete_project_command.py3544 89%
   publish_samples_command.py3044 87%
tabcmd/commands/site
   create_site_command.py3455 85%
   delete_site_command.py2722 93%
   edit_site_command.py3822 95%
   list_command.py771212 84%
   list_sites_command.py2922 93%
tabcmd/commands/user
   add_users_command.py2955 83%
   create_site_users.py581111 81%
   create_users_command.py5999 85%
   delete_site_users_command.py4355 88%
   user_data.py2223131 86%
tabcmd/execution
   _version.py222 0%
   global_options.py12588 94%
   localize.py661111 83%
   logger_config.py6066 90%
   tabcmd_controller.py4277 83%
TOTAL287745984% 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant