feat: add skip_result label to skip result backend storage - #656
Open
vvanglro wants to merge 1 commit into
Open
Conversation
Allow fire-and-forget tasks to opt out of result storage via the skip_result boolean label on @broker.task or kicker.with_labels.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #656 +/- ##
==========================================
+ Coverage 81.29% 81.41% +0.11%
==========================================
Files 69 69
Lines 2577 2593 +16
==========================================
+ Hits 2095 2111 +16
Misses 482 482 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skip_resulttask label so selected tasks can opt out of result backend storage without raisingNoResultError.True/False); missing label means store results as usual; invalid values raiseValueError.skip_result=True, the worker skipsresult_backend.set_resultandpost_savemiddleware hooks, while acknowledgement (includingwhen_saved) still proceeds.with_labelstyping to includebool/bytes.Usage
This is complementary to raising
NoResultErrorfor runtime decisions.Test plan
skip_result=False, invalid value, andwhen_savedack behaviorpytest tests/receiver/passes locallyAI Disclaimer
This PR was developed with the assistance of either Claude or Codex. I've reviewed and verified the changes.