Add headers to cancel nexus task#2798
Merged
Quinn-With-Two-Ns merged 1 commit intotemporalio:masterfrom Feb 27, 2026
Merged
Conversation
tconley1428
approved these changes
Feb 27, 2026
3d98352 to
806beb1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add headers to cancel nexus task. I do have a test we can add along side this, it is decently long for how simple this change is so I left it off for now, but if we want I can add it.
closes #2797
Note
Low Risk
Low risk, narrow change in the test server that only affects metadata propagation for Nexus cancel tasks; main risk is altered expectations in tests that relied on missing headers.
Overview
Ensures Nexus operation cancellation tasks include the original
nexusHeadervalues by copyingdata.scheduledEvent.getNexusHeaderMap()into theio.temporal.api.nexus.v1.Requestbuilt inrequestCancelNexusOperation.This makes cancel-operation polling requests carry the same headers as the originally scheduled Nexus operation, improving parity with start-operation behavior.
Written by Cursor Bugbot for commit 806beb1. This will update automatically on new commits. Configure here.