remove early out in xnnpack pruning policy model traversal#1088
Open
christian-steinmeyer wants to merge 1 commit intotensorflow:masterfrom
Open
remove early out in xnnpack pruning policy model traversal#1088christian-steinmeyer wants to merge 1 commit intotensorflow:masterfrom
christian-steinmeyer wants to merge 1 commit intotensorflow:masterfrom
Conversation
If there are multiple input layers (and therefore paths), this early out might return an empty set before all paths are checked. By simply removing it, the path that doesn't have a next layer ends, nothing is added to the `found_layers` and the other paths continue to be checked.
github-actions
bot
added
the
technique:pruning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there are multiple input layers (and therefore paths), this early out might return an empty set before all paths are checked. By simply removing it, the path that doesn't have a next layer ends, nothing is added to the
found_layersand the other paths continue to be checked.I stumbled upon this with a model that had multiple inputs, one of which was feeding directly into the last (custom) layer. As soon as the traversal found no next layer after it, I got the error message of no valid input branch: