Updated parse_policy_info function in augment.py#13509
Open
LakshmiKalaKadali wants to merge 1 commit intomasterfrom
Open
Updated parse_policy_info function in augment.py#13509LakshmiKalaKadali wants to merge 1 commit intomasterfrom
parse_policy_info function in augment.py#13509LakshmiKalaKadali wants to merge 1 commit intomasterfrom
Conversation
This PR is raised to add more flexible control over the randomness in the augmentation process by changing `level += tf.random.normal([], dtype=tf.float32)` to `level += level_std * tf.random.normal([], dtype=tf.float32)` to the function `parse_policy_info` instead of standard deviation always 1.
LakshmiKalaKadali
requested review from
rachellj218 and
yeqingli
as code owners
LakshmiKalaKadali
added
the
models:official
luotigerlsx
reviewed
Jan 8, 2025
|
|
||
| if level_std > 0: | ||
| level += tf.random.normal([], dtype=tf.float32) | ||
| level += level_std*tf.random.normal([], dtype=tf.float32) |
Member
There was a problem hiding this comment.
This will change the behavior completely. I am worrying about the effects of this. Have you done any tests verifying it won't break existing results using this augmentation ?
Member
There was a problem hiding this comment.
It's OK to bring more flexibility, but the default behavior should keep backward compatibility.
yeqingli
added
the
ready to pull
LakshmiKalaKadali
removed
the
ready to pull
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is raised to add more flexible control over the randomness in the augmentation process by changing
level += tf.random.normal([], dtype=tf.float32)tolevel += level_std * tf.random.normal([], dtype=tf.float32)to the functionparse_policy_infoinstead of standard deviation always 1.